Ensure that stderr/stdout has flush attr before calling it (Sourcery refactored) #1249

sourcery-ai · 2021-09-13T15:59:10Z

Pull Request #1248 refactored by Sourcery.

Since the original Pull Request was opened as a fork in a contributor's
repository, we are unable to create a Pull Request branching from it.

To incorporate these changes, you can either:

Merge this Pull Request instead of the original, or
Ask your contributor to locally incorporate these commits and push them to
the original Pull Request
Incorporate changes via command line
```
git fetch https://github.com/tqdm/tqdm pull/1248/head
git merge --ff-only FETCH_HEAD
git push
```

NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Help us improve this pull request!

codecov · 2021-09-13T16:03:14Z

Codecov Report

Merging #1249 (eac8e7b) into master (140c948) will decrease coverage by 2.44%.
The diff coverage is 76.92%.

❗ Current head eac8e7b differs from pull request most recent head 7b3c166. Consider uploading reports for the commit 7b3c166 to get more accurate results

@@            Coverage Diff             @@
##           master    #1249      +/-   ##
==========================================
- Coverage   89.68%   87.24%   -2.45%     
==========================================
  Files          26       26              
  Lines        1735     1732       -3     
  Branches      287      288       +1     
==========================================
- Hits         1556     1511      -45     
- Misses        133      165      +32     
- Partials       46       56      +10

sourcery-ai · 2022-02-14T15:26:21Z

tqdm/std.py

-            postfix = ', ' + postfix if postfix else ''
+            postfix = f', {postfix}' if postfix else ''


Function tqdm.format_meter refactored with the following changes:

Use f-string instead of string concatenation (use-fstring-for-concatenation)

sourcery-ai · 2022-02-14T15:26:21Z

tqdm/std.py

-                # find unfixed (`pos >= 0`) overflow (`pos >= nrows - 1`)
-                instances = list(filter(
-                    lambda i: hasattr(i, "pos") and last <= i.pos,
-                    cls._instances))
-                # set first found to current `pos`
-                if instances:
+                if instances := list(
+                    filter(
+                        lambda i: hasattr(i, "pos") and last <= i.pos,
+                        cls._instances,
+                    )
+                ):


Function tqdm._decr_instances refactored with the following changes:

Use named expression to simplify assignment and conditional (use-named-expression)

This removes the following comments ( why? ):

# set first found to current `pos` # find unfixed (`pos >= 0`) overflow (`pos >= nrows - 1`)

sourcery-ai · 2022-02-14T15:26:21Z

tqdm/std.py

-        ) or dynamic_ncols:  # pragma: no cover
+        ):  # pragma: no cover
            if dynamic_ncols:
                dynamic_ncols = _screen_shape_wrapper()
                if dynamic_ncols:
                    ncols, nrows = dynamic_ncols(file)
-            else:
-                _dynamic_ncols = _screen_shape_wrapper()
-                if _dynamic_ncols:
-                    _ncols, _nrows = _dynamic_ncols(file)
-                    if ncols is None:
-                        ncols = _ncols
-                    if nrows is None:
-                        nrows = _nrows
-
+            elif _dynamic_ncols := _screen_shape_wrapper():
+                _ncols, _nrows = _dynamic_ncols(file)
+                if ncols is None:
+                    ncols = _ncols
+                if nrows is None:
+                    nrows = _nrows
+
+        elif dynamic_ncols:  # pragma: no cover
+            dynamic_ncols = _screen_shape_wrapper()
+            if dynamic_ncols:
+                ncols, nrows = dynamic_ncols(file)


Function tqdm.__init__ refactored with the following changes:

Split conditional into multiple branches (split-or-ifs)

Remove redundant conditional (remove-redundant-if)

Merge else clause's nested if statement into elif (merge-else-if-into-elif)

Use named expression to simplify assignment and conditional (use-named-expression)

This removes the following comments ( why? ):

# pragma: no cover

sourcery-ai · 2022-02-14T15:26:22Z

tqdm/std.py

-            for obj in iterable:
-                yield obj
+            yield from iterable


Function tqdm.__iter__ refactored with the following changes:

Replace yield inside for loop with yield from (yield-from)

sourcery-ai · 2022-02-14T15:26:22Z

tqdm/std.py

-        self.desc = desc + ': ' if desc else ''
+        self.desc = f'{desc}: ' if desc else ''


Function tqdm.set_description refactored with the following changes:

Use f-string instead of string concatenation (use-fstring-for-concatenation)

sourcery-ai · 2022-02-14T15:26:22Z

tqdm/std.py

-        self.postfix = ', '.join(key + '=' + postfix[key].strip()
-                                 for key in postfix.keys())
+        self.postfix = ', '.join(
+            f'{key}=' + postfix[key].strip() for key in postfix.keys()
+        )
+


Function tqdm.set_postfix refactored with the following changes:

Use f-string instead of string concatenation (use-fstring-for-concatenation)

sourcery-ai · 2022-02-14T15:26:33Z

Sourcery Code Quality Report

❌ Merging this PR will decrease code quality in the affected files by 0.06%.

Quality metrics	Before	After	Change
Complexity	25.85 😞	25.43 😞	-0.42 👍
Method Length	71.76 🙂	72.13 🙂	0.37 👎
Working memory	15.16 😞	15.24 ⛔	0.08 👎
Quality	47.27% 😞	47.21% 😞	-0.06% 👎

Other metrics	Before	After	Change
Lines	1558	1561	3

Changed files	Quality Before	Quality After	Quality Change
tqdm/std.py	47.27% 😞	47.21% 😞	-0.06% 👎

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
tqdm/std.py	tqdm.format_meter	73 ⛔	571.98 ⛔	29 ⛔	2.09% ⛔	Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
tqdm/std.py	tqdm.__init__	50 ⛔	565 ⛔	39 ⛔	3.63% ⛔	Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
tqdm/std.py	tqdm.pandas	53 ⛔	409 ⛔	13 😞	15.07% ⛔	Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
tqdm/std.py	tqdm.pandas.inner_generator	26 😞	196 😞	13 😞	31.76% 😞	Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
tqdm/std.py	tqdm.update	27 😞	154 😞	14 😞	33.57% 😞	Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

⭐ excellent
🙂 good
😞 poor
⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

Ensure that stderr/stdout has flush attr before calling it

da380d6

sourcery-ai bot requested a review from casperdcl as a code owner September 13, 2021 15:59

sourcery-ai bot force-pushed the sourcery/pull-1248 branch 2 times, most recently from 2f43363 to 1ea74c3 Compare September 13, 2021 16:00

Use consistent flush syntax

cd042ba

sourcery-ai bot force-pushed the sourcery/pull-1248 branch 3 times, most recently from 989e110 to b28392f Compare September 13, 2021 16:10

casperdcl force-pushed the master branch from 6574bc1 to fc69d5d Compare September 20, 2021 16:15

sourcery-ai bot force-pushed the sourcery/pull-1248 branch 2 times, most recently from eac8e7b to 7b3c166 Compare October 21, 2021 18:14

moble and others added 2 commits February 14, 2022 09:25

Merge branch 'master' into master

72183b4

'Refactored by Sourcery'

e4c2883

sourcery-ai bot force-pushed the sourcery/pull-1248 branch from 7b3c166 to e4c2883 Compare February 14, 2022 15:26

sourcery-ai bot commented Feb 14, 2022

View reviewed changes

dtrifiro mentioned this pull request Mar 16, 2022

ERROR: unexpected error - 'NoneType' object has no attribute 'flush' iterative/dvc#7465

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ensure that stderr/stdout has flush attr before calling it (Sourcery refactored) #1249

Ensure that stderr/stdout has flush attr before calling it (Sourcery refactored) #1249

sourcery-ai bot commented Sep 13, 2021 •

edited

codecov bot commented Sep 13, 2021 •

edited

sourcery-ai bot Feb 14, 2022

sourcery-ai bot Feb 14, 2022

sourcery-ai bot Feb 14, 2022

sourcery-ai bot Feb 14, 2022

sourcery-ai bot Feb 14, 2022

sourcery-ai bot Feb 14, 2022

sourcery-ai bot commented Feb 14, 2022

		postfix = ', ' + postfix if postfix else ''
		postfix = f', {postfix}' if postfix else ''

		self.desc = desc + ': ' if desc else ''
		self.desc = f'{desc}: ' if desc else ''

Ensure that stderr/stdout has flush attr before calling it (Sourcery refactored) #1249

Are you sure you want to change the base?

Ensure that stderr/stdout has flush attr before calling it (Sourcery refactored) #1249

Conversation

sourcery-ai bot commented Sep 13, 2021 • edited

codecov bot commented Sep 13, 2021 • edited

Codecov Report

sourcery-ai bot Feb 14, 2022

Choose a reason for hiding this comment

sourcery-ai bot Feb 14, 2022

Choose a reason for hiding this comment

sourcery-ai bot Feb 14, 2022

Choose a reason for hiding this comment

sourcery-ai bot Feb 14, 2022

Choose a reason for hiding this comment

sourcery-ai bot Feb 14, 2022

Choose a reason for hiding this comment

sourcery-ai bot Feb 14, 2022

Choose a reason for hiding this comment

sourcery-ai bot commented Feb 14, 2022

Sourcery Code Quality Report

Legend and Explanation

sourcery-ai bot commented Sep 13, 2021 •

edited

codecov bot commented Sep 13, 2021 •

edited