Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo #1162

Merged
merged 3 commits into from May 2, 2021
Merged

Fix typo #1162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e0f3d74
build: PRs can test deploy
casperdcl Apr 23, 2021
f86104a
Merge branch 'devel'
casperdcl Apr 23, 2021
7179c9e
tests: fix typo
May 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Expand Up @@ -131,7 +131,6 @@ jobs:
env:
CODACY_PROJECT_TOKEN: ${{ secrets.CODACY_PROJECT_TOKEN }}
deploy:
if: github.event_name != 'pull_request' || github.head_ref != 'devel'
needs: [check, test, test-os]
runs-on: ubuntu-latest
steps:
Expand Down
2 changes: 1 addition & 1 deletion tests/tests_contrib_logging.py
View file
Open in desktop
Expand Up @@ -124,7 +124,7 @@ def test_should_inherit_console_logger_formatter(self):
with logging_redirect_tqdm(loggers=[logger]):
assert logger.handlers[0].formatter == formatter

def test_should_not_remove_stream_handlers_not_fot_stdout_or_stderr(self):
def test_should_not_remove_stream_handlers_not_for_stdout_or_stderr(self):
logger = logging.Logger('test')
stream_handler = logging.StreamHandler(StringIO())
logger.addHandler(stream_handler)
Expand Down