fix write errors when disowned #1036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casperdcl
added
p0-bug-critical ☢
casperdcl
force-pushed
the
closed-write-errors
branch
from
358dab9
to
b1f5d5f
Compare
8 tasks
Merged
Codecov Report
@@ Coverage Diff @@
## master #1036 +/- ##
==========================================
- Coverage 87.41% 87.23% -0.18%
==========================================
Files 22 22
Lines 1390 1410 +20
Branches 236 239 +3
==========================================
+ Hits 1215 1230 +15
- Misses 151 154 +3
- Partials 24 26 +2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fileis closed (fixes causing job died when stderr closed in the middle #1033)This mirrors the behaviour of
logging.warning(), which doesn't crash the process when disowned/stderris closed.