-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump vendored tqdm version #10266
bump vendored tqdm version #10266
Conversation
- re-patches #10115 - fixes various threading and I/O bugs (see https://tqdm.github.io/releases)
We require contributors to sign our Contributor License Agreement, and we don't have one on file for @casperdcl. In order for us to review and merge your code, please e-sign the PDF at https://conda.io/en/latest/contributing.html#conda-contributor-license-agreement. We then need to manually verify your signature. We will ping the bot to refresh the PR status when we have confirmed your signature. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; holding off on actually merging this until the corresponding conda package shows up in the defaults channel to prevent the conda
recipe from failing.
@anaconda-issue-bot check. |
great; deleted the fork. FYI failing build https://github.com/conda/conda/runs/1242855016 has nothing to do with the merge. |
Hi there, thank you for your contribution to Conda! This pull request has been automatically locked since it has not had recent activity after it was closed. Please open a new issue or pull request if needed. |
If you want to check the diff, it's easiest to use your preferred folder diff tool to compare the upstream folder (https://github.com/tqdm/tqdm/tree/v4.50.2/tqdm) to the one in this PR (https://github.com/tqdm/conda/tree/bump-vendor-tqdm/conda/_vendor/tqdm). Pasted below for convenience: