Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(parser): Fix --discover parsed incorrectly from env #3274

Merged
merged 4 commits into from Apr 26, 2024
Merged

fix(parser): Fix --discover parsed incorrectly from env #3274

merged 4 commits into from Apr 26, 2024

Commits on Apr 26, 2024

  1. fix(parser): Fix --discover parsed incorrectly from env 

    The flag was missing the type specification (`of_type`) and thus
parse.get_env_var did not execute the branch for list, but rather for
single variables.
The fallback in Converter led to a call to `list("abc")`, which
resulted int a list of characters (["a", "b", "c"]).
    @mimre25
    mimre25 committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    6dc64f2 View commit details
    Browse the repository at this point in the history

  2. doc(parser): Rephrase --discover help to avoid confusion 

    The flag expects a list of python executables, but not paths.
Eg `--discover /foo/bar/python` is good, `--discover /foo/bar` or
`--discover /foo/bar/` won't work.
    @mimre25
    mimre25 committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    39c592b View commit details
    Browse the repository at this point in the history

  3. dcos(changelog): Add changelog fragments for tox-dev#3272 and tox-dev… 

    …#3274
    @mimre25
    mimre25 committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    7d73641 View commit details
    Browse the repository at this point in the history

  4. fixup! fix(parser): Fix --discover parsed incorrectly from env 

    py38 typehint fixes
    @mimre25
    mimre25 committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    f3d0063 View commit details
    Browse the repository at this point in the history