New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change stderr color to grey instead of red #2944
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4cac7aa
to
b5b7cb1
Compare
@gaborbernat I can open a poll about the subject, maybe we get other ideas about how we could about the extensive red output on screen, maybe other default color to use than the one I proposed and a lot more feedback from the users. WDYT? PS. At least we do agree on the desire to distinguish between stdout and stderr, as you would not have implemented the red features if you would not. |
I personally prefer the status quo but will listen to other maintainers opinion. The red does not bother me personally, and feels appropiate. |
As stderr is more use for logging than display errors, we better avoid using red and go for a neutral gray color.
b5b7cb1
to
28d79ef
Compare
I don't have strong opinions on the matter, but I agree it is nice to visually distinguish what is stdout and stderr. In my experience with test systems, I've mostly seen stderr colored red, or red background (in web views). I'll try to broaden my perspective a bit and ask around my network see if anyone does have strong opinions and why. |
Thanks to the now red color for stderr of tox 4, I was made aware of many little issues, warnings, and so on, which were overlooked for years, but could lead to issues, like e.g. I am +1 for keeping the red color, and I am avers to change, especially after the recent-ish tox 4 release. We had years of alpha releases for people to give feedback. Now I am happy that things have settled. @ssbarnea I think you are aware of Instead of changing the color for all, would it make sense to make the color configurable? Not that I am a fan of too much customization, but that would be a reasonable compromise. |
I have the use case of a command emitting its output to
And still receive in progress messages to The command uses It would be great to have an optional to disable the forced coloring (and potentially a way to set the color). |
@hashar It is usually a good idea to create a new issue or a new discussion to get more feedback - not many read new comments at closed issues. About disabling coloring - this is already implemented.
Also see https://tox.wiki/en/latest/upgrading.html#output-changes |
I will, and probably come up directly with a pull request when I get the inspiration to write the code :)
This is slightly different since it turns off all tox coloring. I have the use case of not having stderr colored at all (cause some other code is coloring it differently or the output is expected). |
As stderr is more use for logging than display errors, we better avoid using red and go for a neutral gray color.
This should avoid visual strain on users or confusions about presence of red colour on logs, which is almost always a sign of a important, usually fatal, error.
Thanks for contribution
Please, make sure you address all the checklists (for details on how see
development documentation)!
tox -e fix
)docs/changelog
folderBefore
After