Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update how extras are extracted to handle cases with more than 2 groups #2812

Merged
merged 4 commits into from Jan 4, 2023
Merged

update how extras are extracted to handle cases with more than 2 groups #2812

merged 4 commits into from Jan 4, 2023

Commits on Jan 4, 2023

  1. update how extras are extracted to handle cases with more than 2 groups

    @dconathan @gaborbernat
    dconathan authored and gaborbernat committed Jan 4, 2023
    Copy the full SHA
    d75ef6a View commit details
    Browse the repository at this point in the history

  2. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci @gaborbernat
    pre-commit-ci[bot] authored and gaborbernat committed Jan 4, 2023
    Copy the full SHA
    4d4e2a8 View commit details
    Browse the repository at this point in the history

  3. added some type annotations/ignore for mypy checks

    @dconathan @gaborbernat
    dconathan authored and gaborbernat committed Jan 4, 2023
    Copy the full SHA
    7ff1bef View commit details
    Browse the repository at this point in the history

  4. PR feedback 

    Signed-off-by: Bernát Gábor <bgabor8@bloomberg.net>
    @gaborbernat
    gaborbernat committed Jan 4, 2023
    Copy the full SHA
    6dfdf53 View commit details
    Browse the repository at this point in the history