New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide an explanatory message when attempted command parsing produces an empty result #2799
Provide an explanatory message when attempted command parsing produces an empty result #2799
Conversation
…s an empty result
…rsing results are empty (rationale: the input was of the correct type: string, it's the contents (value) of the string that caused issues)
…on command raises a ValueError
…vironment -- that involves accessing and parsing the 'install_command'
…t element) to 'pip install' invocation, so that installation is attempted
…ion statement into pytest.raises 'match' argument
…arametrized argument names
…ion in test case" This reverts commit 44795be.
This reverts commit b6734ff.
…o hold parametrized argument names" This reverts commit 4fce79c.
This reverts commit a7b5f03.
This reverts commit 220b7dc.
This reverts commit ff5d70c.
8244a05
to
6253d62
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please allow pushes to this PR.
Maintainer edits should be allowed @gaborbernat (looks like you were able to push some commits, let me know if I can help) |
seems not |
Why there's like 30 commits here? |
Sometimes (often, recently) I'm a bit tedious about trying to keep the entire commit history for a pull request after it's open (even if it means including reverts, rather than squash committing). It's kinda about being open about errors and mistakes during development. But yep, I do worry that it's annoying to read/review, and wonder how to figure out the balance (per-project/community). I can reduce the commits down if that'd be useful (to a single commit, or to a few logical grouped changes). |
Replaced with #2807 |
Also, please never use merge to make the branch up to date. I always prefer to rebase onto the main, which makes it easier to read and follow. |
Ok, understood 👍 I'll do my best to remember not to do that again here. |
This attempts to clarify the error messaging when the
install_command
entry in atox
environment configuration is empty.tox -e fix
)docs/changelog
folderContinues-from #2715.
Relates to #2695, #2798.