Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip time-machine dep and spinner tests on PyPy #2797

Merged
merged 1 commit into from Dec 31, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions docs/changelog/2797.misc.rst
@@ -0,0 +1,2 @@
Skip the ``time-machine`` dependency and spinner tests on PyPy because
it segfaults on this implementation.
2 changes: 1 addition & 1 deletion pyproject.toml
Expand Up @@ -59,7 +59,7 @@ optional-dependencies.testing = [
"pytest-mock>=3.10",
"pytest-xdist>=3.1",
"re-assert>=1.1",
"time-machine>=2.8.2",
"time-machine>=2.8.2; implementation_name != \"pypy\"",
]
scripts.tox = "tox.run:run"
dynamic = ["version"]
Expand Down
6 changes: 6 additions & 0 deletions tests/conftest.py
Expand Up @@ -39,6 +39,12 @@ def _fmt(msg: str) -> str:
from typing_extensions import Protocol


collect_ignore = []
if sys.implementation.name == "pypy":
# time-machine causes segfaults on PyPy
collect_ignore.append("util/test_spinner.py")


class ToxIniCreator(Protocol):
def __call__(self, conf: str, override: Sequence[Override] | None = None) -> Config: # noqa: U100
...
Expand Down