Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change NO_COLOR interpretation to treat empty string as False and any non-empty string as True #2724

Closed
wants to merge 0 commits into from
Closed

Change NO_COLOR interpretation to treat empty string as False and any non-empty string as True #2724

wants to merge 0 commits into from

Conversation

ptmcg
Copy link
Contributor

@ptmcg ptmcg commented Dec 15, 2022

Thanks for contribution

Please, make sure you address all the checklists (for details on how see
development documentation)!

  • ran the linter to address style issues (tox -e fix)
  • wrote descriptive pull request text
  • ensured there are test(s) validating the fix
  • added news fragment in docs/changelog folder
  • updated/extended the documentation

@ptmcg
Copy link
Contributor Author

ptmcg commented Dec 15, 2022

This looks like a progress bar test failure, not sure how my change affected that, nor why it fails only on Windows with Python 3.9. Suggestions?

@gaborbernat
Copy link
Member

Ah, not sure why this got closed but replaced it with #2727

@ptmcg
Copy link
Contributor Author

ptmcg commented Dec 15, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaborbernat gaborbernat gaborbernat approved these changes

Assignees
No one assigned
Labels
bot:chronographer:provided
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ptmcg @gaborbernat