Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tox3: Support provision of tox 4 with the min_version option #2714

Merged
merged 3 commits into from Dec 14, 2022
Merged

tox3: Support provision of tox 4 with the min_version option #2714

merged 3 commits into from Dec 14, 2022

Conversation

hroncok
Copy link
Contributor

@hroncok hroncok commented Dec 14, 2022

Fixes #2661

Thanks for contribution

  • ran the linter to address style issues (tox -e fix)
  • wrote descriptive pull request text
  • ensured there are test(s) validating the fix
  • added news fragment in docs/changelog folder
  • updated/extended the documentation

@hroncok
Copy link
Contributor Author

hroncok commented Dec 14, 2022

The new test needs to be skipped on old Pythons.

hroncok
hroncok commented Dec 14, 2022
View reviewed changes
tests/unit/session/test_provision.py
with pytest.raises(MissingRequirement) as context:
newconfig(
[],
"""\
[tox]
minversion = {}
{} = {}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if adding a new fixture that evaluates to this expression is worth it or not.

@hroncok
Copy link
Contributor Author

hroncok commented Dec 14, 2022

The new test needs to be skipped on old Pythons.

Done.

@hroncok
Copy link
Contributor Author

hroncok commented Dec 14, 2022

I'm not sure if the Windows failures are related or not. I don't have a Windows development environment to reproduce.

@gaborbernat
Copy link
Member

I'm not sure if the Windows failures are related or not. I don't have a Windows development environment to reproduce.

Can't accept the PR without passing CI so would need to figure it out 👍

@hroncok
Copy link
Contributor Author

hroncok commented Dec 14, 2022

Attempting to solve the UnicodeDecodeError: 'charmap' codec can't decode byte 0x8f in position 164: character maps to <undefined> thing by reading files as utf-8.

@hroncok hroncok force-pushed the tox3_min_version_4 branch 5 times, most recently from 31f9112 to 35c5376 Compare December 14, 2022 19:51
@hroncok

This comment was marked as resolved.

Sign in to view
@hroncok
Copy link
Contributor Author

hroncok commented Dec 14, 2022 •
edited

I went too far trying to bend the code for Python 3.5 and 2.7 and I completely forgot I can run subprocess on bytes and decode the output explicitly. Hopefully, that'll work.

@hroncok
Copy link
Contributor Author

hroncok commented Dec 14, 2022

Now the coverage job failed with:

Could not find the branch to compare to. Does 'origin/master' exist?

Added another commit.

@gaborbernat gaborbernat merged commit b26fd5d into tox-dev:legacy Dec 14, 2022
@hroncok hroncok deleted the tox3_min_version_4 branch December 15, 2022 01:04
hroncok
hroncok commented Dec 15, 2022
View reviewed changes
tests/integration/test_provision_int.py
no_package=True
min_version = 4
[testenv]
commands=python -c "import os; print('assert this')"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The import os part is a leftover from debugging a d should have been removed. Sorry about that.

@hroncok
Copy link
Contributor Author

hroncok commented Dec 15, 2022

Thanks for merging.

@renovate renovate bot mentioned this pull request Sep 15, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaborbernat gaborbernat gaborbernat approved these changes

@asottile asottile Awaiting requested review from asottile

@obestwalter obestwalter Awaiting requested review from obestwalter obestwalter is a code owner

@jugmac00 jugmac00 Awaiting requested review from jugmac00 jugmac00 is a code owner

Assignees
No one assigned
Labels
bot:chronographer:provided
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hroncok @gaborbernat