Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore TOX_SKIP_ENV filtering #2707

Merged
merged 9 commits into from Dec 15, 2022
Merged

Restore TOX_SKIP_ENV filtering #2707

merged 9 commits into from Dec 15, 2022

Commits on Dec 15, 2022

  1. Restore TOX_SKIP_ENV filtering 

    This is still documented in docs/config.rst.  The only missing thing is
the reporting at verbosity level 2.

Fixes tox-dev#2698.
    @mgedmin @gaborbernat
    mgedmin authored and gaborbernat committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    8a28e88 View commit details
    Browse the repository at this point in the history

  2. Add a news fragment

    @mgedmin @gaborbernat
    mgedmin authored and gaborbernat committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    a6887fa View commit details
    Browse the repository at this point in the history

  3. Log about skipped environments 

    Logging this at DEBUG level (tox -vv) felt wrong to me, so I went with
INFO (tox -v).
    @mgedmin @gaborbernat
    mgedmin authored and gaborbernat committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    fe2d258 View commit details
    Browse the repository at this point in the history

  4. Add missing test fixture type annotations

    @mgedmin @gaborbernat
    mgedmin authored and gaborbernat committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    c101da7 View commit details
    Browse the repository at this point in the history

  5. Change the log level to WARNING to match the documentation 

    tox --help says verbosity level 2 is WARNING.
    @mgedmin @gaborbernat
    mgedmin authored and gaborbernat committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    89572aa View commit details
    Browse the repository at this point in the history

  6. Use an instance attribute 

    As far as I can tell, during runtime there's only one EnvSelector
instance, so there's no danger of repeatedly warning about the same
skipped environment when .iter() gets called several times.

Fixes failing unit tests.  (Oops.  I only ran each test in isolation,
because the entire test suite is a bit slow.)
    @mgedmin @gaborbernat
    mgedmin authored and gaborbernat committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    c13c9db View commit details
    Browse the repository at this point in the history

  7. PR feedback 

    Signed-off-by: Bernát Gábor <bgabor8@bloomberg.net>
    @gaborbernat
    gaborbernat committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    924e32c View commit details
    Browse the repository at this point in the history

  8. Add CLI flag too 

    Signed-off-by: Bernát Gábor <bgabor8@bloomberg.net>
    @gaborbernat
    gaborbernat committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    ad3e3ed View commit details
    Browse the repository at this point in the history

  9. fix tests 

    Signed-off-by: Bernát Gábor <bgabor8@bloomberg.net>
    @gaborbernat
    gaborbernat committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    449d884 View commit details
    Browse the repository at this point in the history