Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PKG_CONFIG_PATH to default passenv #2700

Merged
merged 1 commit into from Dec 13, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions docs/changelog/2700.feature.rst
@@ -0,0 +1,2 @@
Add ``PKG_CONFIG_PATH`` to the default pass through environment list for python tox environments -
by :user:`gaborbernat`.
1 change: 1 addition & 0 deletions src/tox/tox_env/python/api.py
Expand Up @@ -97,6 +97,7 @@ def _default_pass_env(self) -> list[str]:
"NUMBER_OF_PROCESSORS", # multiprocessing.cpu_count()
],
)
env.extend(["PKG_CONFIG_PATH"]) # used by binary extensions during installation
env.extend(["REQUESTS_CA_BUNDLE"])
return env

Expand Down
2 changes: 1 addition & 1 deletion tests/session/cmd/test_show_config.py
Expand Up @@ -106,7 +106,7 @@ def test_pass_env_config_default(tox_project: ToxProjectCreator, stdout_is_atty:
+ (["PROGRAMDATA"] if is_win else [])
+ (["PROGRAMFILES"] if is_win else [])
+ (["PROGRAMFILES(x86)"] if is_win else [])
+ ["REQUESTS_CA_BUNDLE", "SSL_CERT_FILE"]
+ ["PKG_CONFIG_PATH", "REQUESTS_CA_BUNDLE", "SSL_CERT_FILE"]
+ (["SYSTEMDRIVE", "SYSTEMROOT", "TEMP"] if is_win else [])
+ (["TERM"] if stdout_is_atty else [])
+ (["TMP", "USERPROFILE"] if is_win else ["TMPDIR"])
Expand Down