Better handling of build backend without editable support and add --exit-and-dump-after flag #2597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaborbernat
force-pushed
the
main
branch
3 times, most recently
from
e36c5c4
to
3be37e8
Compare
…xit-and-dump-after flag Signed-off-by: Bernát Gábor <bgabor8@bloomberg.net>
nsoranzo
reviewed
Dec 9, 2022
| if spec.implementation is not None: | ||
| if spec.implementation.lower() in INTERPRETER_SHORT_NAMES and env_name is not None: | ||
| candidates.append(factor) | ||
| impl = spec.implementation or "python" |
There was a problem hiding this comment.
@gaborbernat This change has the unintended (I presume) effect of interpreting a numeric factor (e.g. 2105) as a candidate base python, breaking previously valid environment names (e.g. py37-foo-2105) by raising ValueError: conflicting factors py37, 2105 in py37-foo-2105.
Example GitHub workflow build: https://github.com/galaxyproject/planemo/actions/runs/3654111042/jobs/6174245903 for tox.ini https://github.com/galaxyproject/planemo/blob/nsoranzo-patch-1/tox.ini
There was a problem hiding this comment.
That error is a bug 🤣 please fill an issue for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2567.
Resolves #2595.