Add missing build test dependency #2577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaborbernat
requested changes
Dec 1, 2022
pyproject.toml
Outdated
| @@ -44,6 +44,7 @@ optional-dependencies.docs = [ | |||
| "towncrier>=22.8", | |||
| ] | |||
| optional-dependencies.testing = [ | |||
| "build>=0.9.0", | |||
There was a problem hiding this comment.
Let's make it build[virtualenv] and you can drop trailing .0-s
Signed-off-by: Bernát Gábor <bgabor8@bloomberg.net>
|
Thank you! |
|
@ssbarnea was there a particular reason for bumping the chardet dependency (and others) here? |
|
@jcristau I do not remember and do not plan to spend my free time investigating it. Feel free to check their changelog and see if there are good or not reasons for the bump. |
|
I did, and can't see any. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2576
Thanks for contribution
Please, make sure you address all the checklists (for details on how see
development documentation)!
tox -e fix_lint)docs/changelogfolder