Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SetuptoolsDeprecationWarning about using --global-option #2487

Merged
merged 1 commit into from Sep 8, 2022
Merged

Fix SetuptoolsDeprecationWarning about using --global-option #2487

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/changelog/2478.bugfix.rst
View file
Open in desktop
@@ -0,0 +1 @@
Fixed ``SetuptoolsDeprecationWarning`` about using ``--global-option`` -- by :user:`adamchainz`
2 changes: 1 addition & 1 deletion src/tox/helper/build_isolated.py
View file
Open in desktop
Expand Up @@ -38,5 +38,5 @@ def _ensure_module_in_paths(module, paths):
if backend_obj:
backend = getattr(backend, backend_obj)

basename = backend.build_sdist(dist_folder, {"--global-option": ["--formats=gztar"]})
basename = backend.build_sdist(dist_folder, {"--build-option": ["--formats=gztar"]})
print(basename)
1 change: 1 addition & 0 deletions tests/unit/package/builder/test_package_builder_isolated.py
View file
Open in desktop
Expand Up @@ -25,6 +25,7 @@ def test_verbose_isolated_build(initproj, mock_venv, cmd):
},
)
result = cmd("--sdistonly", "-v", "-v", "-v", "-e", "py")
assert "The arguments ['--formats=gztar'] were given via `--global-option`." not in result.err
assert "running sdist" in result.out, result.out
assert "running egg_info" in result.out, result.out
assert "example123-0.5.tar.gz" in result.out, result.out
Expand Down