Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fallback to "python" environment when "isolated_build = true" is set #2475

Merged
merged 2 commits into from Aug 8, 2022

Conversation

Unrud
Copy link

@Unrud Unrud commented Aug 7, 2022

Skip the section generated by isolated_build = true when collection all environments instead of removing the isolated_build_env afterwards.

Fixes #2474

Contribution checklist:

(also see CONTRIBUTING.rst for details)

  • wrote descriptive pull request text
  • added/updated test(s)
  • updated/extended the documentation
  • added relevant issue keyword
    in message body
  • added news fragment in changelog folder
  • added yourself to CONTRIBUTORS (preserving alphabetical order)

@Unrud Unrud changed the title Skip section generated by isolated_build Fix fallback to "python" environment when "isolated_build = true" is set Aug 7, 2022
Skip the section generated by ``isolated_build = true`` when collection all environments instead of removing the ``isolated_build_env`` afterwards.
Copy link
Member

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to add a test for this.

@Unrud
Copy link
Author

Unrud commented Aug 8, 2022

I've added a unit test.

@gaborbernat gaborbernat merged commit ff847c6 into tox-dev:master Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"envlist" default with "isolated_build = true" broken
2 participants