ASCII output for --parallel report lines #2164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This class provides a single interface for spinner strings where we ideally want to report Unicode but want to fall back to ASCII when the terminal doesn't support it.
brettcs
requested review from
asottile,
gaborbernat and
obestwalter
as code owners
|
Sorry about the test failures on older Pythons. I can tackle those but it might be a few days. |
brettcs
force-pushed
the
parallel-ascii-report
branch
from
1da9a6e
to
833e4b1
Compare
gaborbernat
approved these changes
Aug 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a branch to fix #1421 by providing ASCII equivalent messages for the OK/FAIL/SKIP lines that summarize the result for each environment.
I chose strings reminiscent of the sysvinit boot service banners on older Linux distros. If you'd rather use something else, of course it's no problem for anyone else to switch out those strings. The code should continue to work no problem.
Hope this helps!