Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use {env}/bin instead of {env}/Scripts when Python is from MSYS2 on Windows. #1983

Merged
merged 2 commits into from Apr 6, 2021
Merged

Use {env}/bin instead of {env}/Scripts when Python is from MSYS2 on Windows. #1983

merged 2 commits into from Apr 6, 2021

Conversation

jschwartzentruber
Copy link

MSYS2 prefers a Linux filesystem layout, but is otherwise a native Windows interpreter.

This was causing warnings like:

WARNING: test command found but not installed in testenv
  cmd: C:/Users/User/Desktop/msys64-JHtqq6ULSEu38CxK8FxfLQ/mingw64/bin/python.EXE
  env: C:/Users/User/source/repos/fuzzfetch/.tox/py38
Maybe you forgot to specify a dependency? See also the allowlist_externals envconfig setting.

... despite the fact that C:/Users/User/source/repos/fuzzfetch/.tox/py38/bin/python.exe did exist.

Fixes #1982.

gaborbernat
gaborbernat requested changes Mar 30, 2021
View reviewed changes
src/tox/config/__init__.py Outdated Show resolved Hide resolved
docs/changelog/1982.bugfix.rst Outdated Show resolved Hide resolved
@jschwartzentruber
Copy link
Author

jschwartzentruber commented Apr 1, 2021 •
edited

Added a test. I also renamed the InterpreterInfo attribute from pathsep to os_sep, because os.pathsep is something else.

gaborbernat
gaborbernat requested changes Apr 1, 2021
View reviewed changes
src/tox/config/__init__.py Outdated Show resolved Hide resolved
@jschwartzentruber
Use {env}/bin instead of {env}/Scripts when Python is from MSYS2 …
bfce0b5 
…on Windows.

MSYS2 prefers a Linux filesystem layout, but is otherwise a native
Windows interpreter.

Fixes tox-dev#1982
gaborbernat
gaborbernat requested changes Apr 5, 2021
View reviewed changes
Copy link
Member

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix the CI, please?

@gaborbernat gaborbernat merged commit 8d6a324 into tox-dev:master Apr 6, 2021
@jschwartzentruber jschwartzentruber deleted the fix-1982 branch April 6, 2021 18:16
ssbarnea pushed a commit to ssbarnea/tox that referenced this pull request Apr 19, 2021
@jschwartzentruber @ssbarnea
Use {env}/bin instead of {env}/Scripts when Python is from MSYS2 on W…
7e97a79 
…indows. (tox-dev#1983)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaborbernat gaborbernat gaborbernat requested changes

@asottile asottile Awaiting requested review from asottile

@obestwalter obestwalter Awaiting requested review from obestwalter

Assignees
No one assigned
Labels
bot:chronographer:provided
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tox uses wrong virtualenv PATH under MSYS
2 participants
@jschwartzentruber @gaborbernat