Skip time-machine dep and spinner tests on PyPy #2797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The time-machine package is deeply relying on CPython implementation details and causes segfaults on PyPy. Pull the dependency in only on implementations other than PyPy, and skip collecting the spinner tests on PyPy since they require it.
|
I think this is the least intrusive solution. If you'd prefer another one, please let me know. |
gaborbernat
approved these changes
Dec 31, 2022
|
Thanks! |
Closed
descope bot
added a commit
to descope/django-descope
that referenced
this pull request
Jan 16, 2023
This PR contains the following updates: | Package | Type | Update | Change | Pending | |---|---|---|---|---| | [tox](https://togithub.com/tox-dev/tox) ([changelog](https://tox.wiki/en/latest/changelog.html)) | dev | patch | `4.1.2` -> `4.1.3` | `4.3.2` (+11) | --- ### Release Notes <details> <summary>tox-dev/tox</summary> ### [`v4.1.3`](https://togithub.com/tox-dev/tox/releases/tag/4.1.3) [Compare Source](https://togithub.com/tox-dev/tox/compare/4.1.2...4.1.3) #### What's Changed - Relax test_list_installed_deps() to allow other packages by [@​mgorny](https://togithub.com/mgorny) in [tox-dev/tox#2796 - Skip time-machine dep and spinner tests on PyPy by [@​mgorny](https://togithub.com/mgorny) in [tox-dev/tox#2797 - Reuse package_env with --installpkg by [@​gaborbernat](https://togithub.com/gaborbernat) in [tox-dev/tox#2803 - issue 2695/tox4 install command breaking change docs by [@​gaborbernat](https://togithub.com/gaborbernat) in [tox-dev/tox#2806 - Better message when command parsing on empty input by [@​gaborbernat](https://togithub.com/gaborbernat) in [tox-dev/tox#2807 **Full Changelog**: tox-dev/tox@4.1.2...4.1.3 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC45OS4yIiwidXBkYXRlZEluVmVyIjoiMzQuOTkuMiJ9--> Co-authored-by: descope[bot] <descope[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The time-machine package is deeply relying on CPython implementation details and causes segfaults on PyPy. Pull the dependency in only on implementations other than PyPy, and skip collecting the spinner tests on PyPy since they require it.
Thanks for contribution
Please, make sure you address all the checklists (for details on how see
development documentation)!
tox -e fix)docs/changelogfolder