New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tox3: Support provision of tox 4 with the min_version option #2714
Conversation
The new test needs to be skipped on old Pythons. |
3507d3c
to
34b2d4b
Compare
with pytest.raises(MissingRequirement) as context: | ||
newconfig( | ||
[], | ||
"""\ | ||
[tox] | ||
minversion = {} | ||
{} = {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if adding a new fixture that evaluates to this expression is worth it or not.
Done. |
I'm not sure if the Windows failures are related or not. I don't have a Windows development environment to reproduce. |
Can't accept the PR without passing CI so would need to figure it out 👍 |
Attempting to solve the |
31f9112
to
35c5376
Compare
This comment was marked as resolved.
This comment was marked as resolved.
35c5376
to
089ec3f
Compare
I went too far trying to bend the code for Python 3.5 and 2.7 and I completely forgot I can run subprocess on bytes and decode the output explicitly. Hopefully, that'll work. |
Now the coverage job failed with:
Added another commit. |
no_package=True | ||
min_version = 4 | ||
[testenv] | ||
commands=python -c "import os; print('assert this')" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The import os part is a leftover from debugging a d should have been removed. Sorry about that.
Thanks for merging. |
Fixes #2661
Thanks for contribution
tox -e fix
)docs/changelog
folder