Skip to content

Commit

Permalink
PR feedback
Browse files Browse the repository at this point in the history
Signed-off-by: Bernát Gábor <bgabor8@bloomberg.net>
  • Loading branch information
gaborbernat committed Dec 7, 2022
1 parent 90c6724 commit af8505a
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 3 deletions.
1 change: 1 addition & 0 deletions docs/changelog/2587.doc.rst
@@ -0,0 +1 @@
Enumerate breaking changes of tox 4 in the FAQ, and also list major new improvements - by :user:`gaborbernat`.
1 change: 1 addition & 0 deletions docs/changelog/2602.doc.rst
@@ -0,0 +1 @@
Document in the FAQ that tox 4 will raise a warning when finding conflicting environment names - by :user:`gaborbernat`.
1 change: 1 addition & 0 deletions docs/changelog/2608.bugfix.rst
@@ -0,0 +1 @@
The temporary folder within the tox environment was named ``.temp`` instead of ``.tmp`` - by :user:`gaborbernat`.
4 changes: 2 additions & 2 deletions docs/faq.rst
Expand Up @@ -100,8 +100,8 @@ Here is a non-exhaustive list of these.
legacy (le) legacy entry-point command
The ``exec`` and ``depends`` are brand new features. Other subcommands are a more powerful versions of previously
existing single flags (e.g. ``-av`` is now succeeded by the ``list`` subcommand). All subcommand have a one or two
character shortcut for less typing on the CLI (e.g. ``tox run`` can be abbreviated to ``tox r``). For more details
existing single flags (e.g. ``-av`` is now succeeded by the ``list`` subcommand). All subcommands have a one or two
character shortcuts for less typing on the CLI (e.g. ``tox run`` can be abbreviated to ``tox r``). For more details
see :ref:`cli`.
- Startup times should be improved because now we no longer eagerly load all configurations for all environments, but
instead these are performed lazily when needed. Side-effect of this is that if you have an invalid configuration will
Expand Down
2 changes: 1 addition & 1 deletion src/tox/config/sets.py
Expand Up @@ -199,7 +199,7 @@ def work_dir_builder(conf: Config, env_name: str | None) -> Path: # noqa: U100
self.add_config(
keys=["temp_dir"],
of_type=Path,
default=lambda conf, _: cast(Path, self["tox_root"]) / ".temp", # noqa: U100, U101
default=lambda conf, _: cast(Path, self["tox_root"]) / ".tmp", # noqa: U100, U101
desc="temporary directory cleaned at start",
)

Expand Down

0 comments on commit af8505a

Please sign in to comment.