Skip to content

Commit

Permalink
PR feedback
Browse files Browse the repository at this point in the history
Signed-off-by: Bernát Gábor <gaborjbernat@gmail.com>
  • Loading branch information
gaborbernat committed Dec 31, 2022
1 parent c5bb228 commit 5ccf2b3
Showing 1 changed file with 6 additions and 9 deletions.
Expand Up @@ -51,15 +51,6 @@ def test_load_dependency_many_extra(pkg_with_extras: PathDistribution) -> None:
assert str(left) == str(right)


def test_load_dependency_poetry_many_extra() -> None:
requires = [Requirement('filelock<4.0.0,>=3.9.0; extra == "extras1" or extra == "extras2"')]
result = dependencies_with_extras(requires, {"extras1"}, "")
exp = [Requirement("filelock<4.0.0,>=3.9.0")]
for left, right in zip_longest(result, exp):
assert isinstance(right, Requirement)
assert str(left) == str(right)


def test_loads_deps_recursive_extras() -> None:
requires = [
Requirement("no-extra"),
Expand All @@ -72,3 +63,9 @@ def test_loads_deps_recursive_extras() -> None:
]
result = dependencies_with_extras(requires, {"dev"}, "name")
assert [str(i) for i in result] == ["no-extra", "dep1[magic]", "dep1", "dep2[a,b]"]


def test_load_dependency_requirement_or_extras() -> None:
requires = [Requirement('filelock<4.0.0,>=3.9.0; extra == "extras1" or extra == "extras2"')]
result = dependencies_with_extras(requires, {"extras1"}, "")
assert [str(r) for r in result] == ["filelock<4.0.0,>=3.9.0"]

0 comments on commit 5ccf2b3

Please sign in to comment.