Timeout on body #303
Merged
Timeout on body #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes tower-rs#295 Add a timeout on inactive bodies, both on request and response bodies. Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de> Co-authored-by: Harry Barber <hlbarber@amazon.com>
Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de>
Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de>
Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de>
Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de>
hlbarber
reviewed
Oct 11, 2022
|
|
||
| pin_project! { | ||
| /// Wrapper around a [`http_body::Body`] to time out if data is not ready within the specified duration. | ||
| pub struct TimeoutBody<B> { |
There was a problem hiding this comment.
Taking a big step back, this could live in http_body crate if there was a standard interface for sleep futures.
There was a problem hiding this comment.
Yeah, I think we do want to add a timeout body in http-body-utils, that said we can start with that code in here. I think this is the path I am going with for the retry stuff as well.
Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de>
hlbarber
reviewed
Oct 12, 2022
LucioFranco
requested changes
Oct 18, 2022
|
|
||
| pin_project! { | ||
| /// Wrapper around a [`http_body::Body`] to time out if data is not ready within the specified duration. | ||
| pub struct TimeoutBody<B> { |
There was a problem hiding this comment.
Yeah, I think we do want to add a timeout body in http-body-utils, that said we can start with that code in here. I think this is the path I am going with for the retry stuff as well.
Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de>
hlbarber
approved these changes
Oct 21, 2022
added 2 commits
October 24, 2022 10:53
Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de>
LucioFranco
requested changes
Oct 25, 2022
Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de>
Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de>
LucioFranco
requested changes
Oct 27, 2022
Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de>
Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de>
Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de>
LucioFranco
reviewed
Oct 28, 2022
LucioFranco
approved these changes
Oct 28, 2022
Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de>
Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Explained in #295. This PR closes #295.
Solution
Wrap the body in a
TimeoutBody.TimeoutBodywill poll a sleep future to check whether the body is inactive and register itself to be awoken. The sleep future is polled and checked right after creation to avoid a potential delay in execution making the executor to never poll the sleep future again. That is, if between creation andpollon sleep the time runs out and the sleep is done, a timeout error is immediately returned