Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Panic if * is used with AllowOrigin::list #285

Merged
merged 3 commits into from Jul 15, 2022
Merged

Panic if * is used with AllowOrigin::list #285

merged 3 commits into from Jul 15, 2022

Conversation

davidpdrsn
Copy link
Member

@davidpdrsn davidpdrsn requested a review from jplatte July 15, 2022 11:36
@davidpdrsn davidpdrsn mentioned this pull request Jul 15, 2022
Closed
@jplatte
Copy link
Collaborator

jplatte commented Jul 15, 2022

I wonder whether we should instead panic. I don't see why you would legitimately provide both a wildcard which allows any origin, and other values.

@davidpdrsn
Copy link
Member Author

Yeah that's fine with me as well.

@davidpdrsn
Copy link
Member Author

@jplatte I've changed it to panic.

@davidpdrsn davidpdrsn changed the title Handle * in AllowOrigin::list Panic if * is used with AllowOrigin::list Jul 15, 2022
@davidpdrsn davidpdrsn merged commit 913683b into master Jul 15, 2022
@davidpdrsn davidpdrsn deleted the cors-handle-wildcard-in-allow-origin-lists branch July 15, 2022 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jplatte jplatte jplatte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cors_multiple_origins
2 participants
@davidpdrsn @jplatte