Skip to content
This repository has been archived by the owner on Apr 16, 2020. It is now read-only.

UPDATE: Update the dependency(branch) of the h2 and typer #208

Open
wants to merge 1 commit into
base: std-future
Choose a base branch
from
Open

UPDATE: Update the dependency(branch) of the h2 and typer #208

wants to merge 1 commit into from

Conversation

UkonnRa
Copy link

@UkonnRa UkonnRa commented Sep 25, 2019

--- Update ---

For these issues, rust-lang/futures-rs#1776 and rust-lang/futures-rs#1090, maybe it's better to impl Stream<Item = Result<T, E>> rather than TryStream, so as TryFuture.

--- Original ---
However, this branch is still not working, for:

107 | impl<T: Unpin> TryStream for Once<T> {
    |                ^^^^^^^^^ the trait `futures_core::stream::Stream` is not implemented for `generic::server::unary::Once<T>`
    |
    = note: required because of the requirements on the impl of `futures_core::stream::private_try_stream::Sealed` for `generic::server::unary::Once<T>`

@LucioFranco
Copy link
Member

@UkonnRa the std-future branch is currently very far behind and in a stale state right now. I would recommend waiting a week or so and well have something that will make this all much easier to interact with std::future::Future.

@UkonnRa
Copy link
Author

UkonnRa commented Sep 25, 2019

So could I access the latest branch of tower-rs with the latest rs-futures 0.3? I mean, I found that std-future branch is already the latest branch.

@LucioFranco
Copy link
Member

@UkonnRa so tower has a 0.3.x branch for 0.3 futures. tower-grpc currently has not been updated as we have focused on updating the rest of the stack. But we will have something very shortly for this. So I would wait to use tower-grpc and std future for now. The std-future branch here was a test to see if we could upgrade tower-grpc and we ran into a few issues. But it is our top priority right now.

@UkonnRa
Copy link
Author

UkonnRa commented Sep 25, 2019

OK I get it, so tower-grpc is blocked by tower, tower-grpc will be updated after the tower side work is finished. That's fair~

One more thing, now tower is almost no doc/guide at all. I cannot even understand the difference among tower, hyper and tokio....

@LucioFranco
Copy link
Member

@UkonnRa I will give an update to this repo, probably the readme and an issue once we have the new stuff out. Thanks for the patience <3

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants