Remove Boxing of response futures #6
Conversation
jonhoo
force-pushed
the
no-box
branch
2 times, most recently
from
4bcbbb2
to
bb9d18c
Compare
jonhoo
force-pushed
the
no-box
branch
2 times, most recently
from
531d6bf
to
cb1df16
Compare
| @@ -37,6 +37,7 @@ | |||
| //! the client helper as `Client` in the protocol module you're working with (e.g., | |||
| //! [`pipeline::Client`]), and the server helper as `Server` in the same place. | |||
| #![deny(missing_docs)] | |||
| #![feature(type_alias_impl_trait)] | |||
There was a problem hiding this comment.
I wonder if you can feature flag this, a bit unfortunate since this doesn't seem like its going to hit stable anytime soon :(
There was a problem hiding this comment.
I really want this PR to land, but yeah, not looking to stabilize for a while. It would essentially be an unstable feature flag, which isn't great.. :/
There was a problem hiding this comment.
I wonder if you could do this with some sort of generic or something maybe but yeah, go head we can fix later but we should probably not get things stuck on the nightly drug. I just asked in zulip about this feature not gonna be anytime soon :(
There was a problem hiding this comment.
So you're proposing we fold this under, like feature = "nightly-nobox"? I don't think that'll work, because then the feature wouldn't be additive. If something that depends on tokio-tower without the feature somehow got compiled with the feature, it might not compile.
There was a problem hiding this comment.
yeah im not sure but happy to not block this now for it.
There was a problem hiding this comment.
I think putting a version out there with non-additive features is just asking for downstream users to have issues sadly. I think it's fine to keep the Box version for now, and then have an explicit git opt-in for those (like me) who want to squeeze the last little bit out.
jonhoo
force-pushed
the
no-box
branch
3 times, most recently
from
4c2c01f
to
4254420
Compare
jonhoo
force-pushed
the
no-box
branch
2 times, most recently
from
6476a20
to
e58bb90
Compare
Waiting on rust-lang/rust#63063.
Waiting on rust-lang/rust#63063.