Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Layout/SpaceAroundOperators cop #83

Merged

Conversation

koic
Copy link
Collaborator

@koic koic commented Oct 25, 2020

Follow rails/rails#40436.

This PR enables Layout/SpaceAroundOperators cop.
rails/rails#40436 setting requires RuboCop 1.0 and RuboCop AST 1.0.1 or higher.
rubocop/rubocop#8919

Therefore this PR will be dropping versions that is lack for that requires.

Follow rails/rails#40436.

This PR enables `Layout/SpaceAroundOperators` cop.
rails/rails#40436 setting requires
RuboCop 1.0 and RuboCop AST 1.0.1 or higher.
rubocop/rubocop#8919

Therefore this PR will be dropping versions that is lack for that requires.
@koic
Copy link
Collaborator Author

koic commented Oct 26, 2020

@toshimaru I think rubocop-rails_config can be released 1.0 after merging this PR.
cf: #71

@toshimaru
Copy link
Owner

@koic That's what I'm exactly thinking.
Also I'm considering dropping Ruby 2.4, which is EOL-ed, on v1.0.0 release. What do you think ❓

@koic
Copy link
Collaborator Author

koic commented Oct 26, 2020

Good point. RuboCop core still supports Ruby 2.4. So, I think we can support Ruby 2.4 if the maintenance cost is not high.
https://docs.rubocop.org/rubocop/1.0/compatibility.html#support-matrix

@toshimaru
Copy link
Owner

To give people extra time for a smooth transition, we’ve customarily provided support for about one year after EOL of MRI version. This means that if Ruby 2.4 reaches its EOL in Spring 2020, it would be supported by RuboCop (at least) until Spring 2021.

https://docs.rubocop.org/rubocop/1.0/compatibility.html#support-matrix

Okay, rubocop still supports Ruby 2.4 until Spring 2021.

I think we can support Ruby 2.4 if the maintenance cost is not high.

Personally, I was thinking it'd be better to drop Ruby 2.4,
but as you said, the maintenance cost is not so high, so I keep it as is. 👍

@toshimaru toshimaru merged commit fd4ceb3 into toshimaru:main Oct 27, 2020
@koic koic deleted the enable_layout_space_around_operators_cop branch October 27, 2020 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants