New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove return objects list in `bulk_create` #1615

Merged

abondar merged 1 commit into tortoise:develop from Abdeldjalil-H:change-bulk-create

May 14, 2024

Contributor

Abdeldjalil-H commented May 14, 2024

Description

A detailed description can be found in #1614

Motivation and Context

bulk_create method does not change the passed objects, so there is no need to return them.

How Has This Been Tested?

This was tested on existing tests.

Checklist:

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have added the changelog accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
All new and existing tests passed.


          remove return objects list in bulk_create

beaf297

coveralls commented May 14, 2024

Pull Request Test Coverage Report for Build 9079752800

Details

3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.001%) to 87.933%

Totals
Change from base Build 9076367500:	-0.001%
Covered Lines:	5784
Relevant Lines:	6482

💛 - Coveralls

abondar approved these changes

View reviewed changes

abondar merged commit ca50d99 into tortoise:develop

7 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment