Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fastapi example test not working and make deps raise SolverProblemError. #1247

Merged
merged 2 commits into from Sep 13, 2022

Conversation

waketzheng
Copy link
Contributor

Description

Fix these issues: #1246 #1029

Motivation and Context

I got the SolverProblemError yesterday and fix it by make up
The latest version of fastapi recomment to use anyio/httpx for async test:
https://fastapi.tiangolo.com/advanced/async-tests/
And use asgi-lifespan for tortoise init db and close connections when testing

How Has This Been Tested?

make test worked as expected
cd examples/fastapi && PYTHONPATH=. pytest _tests.py worked too

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added the changelog accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed. make test worked.

@long2ice long2ice merged commit 312165c into tortoise:develop Sep 13, 2022
@long2ice
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants