Swtich to EasyMDE #76
Conversation
StefanUlbrich
force-pushed
the
feature/easy_mde
branch
from
32fab49
to
647a2df
Compare
SimpleMDE is no longer supported and as an open security issue. EasyMDE is a maintianed fork.
StefanUlbrich
force-pushed
the
feature/easy_mde
branch
from
647a2df
to
435865b
Compare
|
@thijstriemstra will this be merged and is this project still maintained? |
|
@jeriox , @thijstriemstra , I cannot merge without write access |
|
Hey all, Sorry for the delay and radio silence. |
| @@ -35,9 +35,23 @@ WAGTAILMARKDOWN_EXTENSIONS = ["toc", "sane_lists"] | |||
| ### Installation | |||
| Alpha release is available on Pypi - https://pypi.org/project/wagtail-markdown/ - installable via `pip install wagtail-markdown`. It's not a production ready release. | |||
|
|
|||
| The SimpleMDE editor uses FontAwesome for its widget icons. You can install [Wagtail FontAwesome](https://gitlab.com/alexgleason/wagtailfontawesome) via `pip install wagtailfontawesome`, or if you already have the stylesheet, add the following to a `wagtail_hooks` module in a registered app in your project: | |||
| The EasyMDE editor uses [FontAwesome 5](https://fontawesome.com/how-to-use/graphql-api/intro/getting-started) for its widget icons. You can get it with | |||
There was a problem hiding this comment.
According to
Locally it GETs:
https://maxcdn.bootstrapcdn.com/font-awesome/latest/css/font-awesome.min.css, then https://maxcdn.bootstrapcdn.com/font-awesome/latest/fonts/fontawesome-webfont.woff2?v=4.7.0
regardless whether you use wagtailfontawesome, or the manual download + hook as described below.
https://github.com/Ionaru/easy-markdown-editor/#options-list states:
autoDownloadFontAwesome: If set to true, force downloads Font Awesome (used for icons). If set to false, prevents downloading. Defaults to undefined, which will intelligently check whether Font Awesome has already been included, then download accordingly.
So the best bet would be to initialize EasyMDE with autoDownloadFontAwesome: false
|
Thank you for this @StefanUlbrich. Made a few tweaks around FontAwesome autodownload and merged it. Turns out SimpleMDE was doing the same autodownload thing - https://github.com/sparksuite/simplemde-markdown-editor/blob/master/src/js/simplemde.js#L1274-L1297 so the wagtailfontawesome dependency was erroneous |
SimpleMDE is no longer supported and as an open security issue.
EasyMDE is a maintianed fork.
This PR directly addresses #72
Additions: