Support Kubernetes v1.23 #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peng225
force-pushed
the
support_kubernetes_v1.23
branch
2 times, most recently
from
23a1ae6
to
44daf36
Compare
Signed-off-by: Shinya Hayashi <shinya-hayashi@cybozu.co.jp>
Signed-off-by: Shinya Hayashi <shinya-hayashi@cybozu.co.jp>
Signed-off-by: Shinya Hayashi <shinya-hayashi@cybozu.co.jp>
Signed-off-by: Shinya Hayashi <shinya-hayashi@cybozu.co.jp>
Signed-off-by: Shinya Hayashi <shinya-hayashi@cybozu.co.jp>
Signed-off-by: Shinya Hayashi <shinya-hayashi@cybozu.co.jp>
peng225
force-pushed
the
support_kubernetes_v1.23
branch
from
44daf36
to
08debd6
Compare
peng225
requested review from
a team,
toshipp,
llamerada-jp and
cupnes
and removed request for
a team and
llamerada-jp
llamerada-jp
requested changes
Feb 3, 2022
There was a problem hiding this comment.
Would you update here to 1.17 form 1.16?
https://github.com/topolvm/topolvm/blob/v0.10.4/example/Vagrantfile#L21
|
Would you regenerate *.pg.go files using updated protoc command. |
llamerada-jp
requested changes
Feb 3, 2022
| @@ -12,5 +12,5 @@ sources: | |||
| dependencies: | |||
| - name: cert-manager | |||
| repository: https://charts.jetstack.io | |||
| version: 1.3.1 | |||
| version: 1.7.0 | |||
There was a problem hiding this comment.
Could you modify charts/topolvm/README.md.gotmpl and deploy/README.md to update version in documents.
| @@ -12,7 +12,7 @@ | |||
| - [How to expose free storage capacity of nodes](#how-to-expose-free-storage-capacity-of-nodes) | |||
| - [How to annotate resources](#how-to-annotate-resources) | |||
| - [Setting of divisors](#setting-of-divisors) | |||
| - [Ephemeral Inline Volume](#ephemeral-inline-volume) | |||
| - [Ephemeral Inline Volume (**deprecated**)](#ephemeral-inline-volume-deprecated) | |||
There was a problem hiding this comment.
Would you revert the changes in this file? Because this document is a proposal.
cupnes
requested review from
daichimukai and
cupnes
and removed request for
daichimukai
cupnes
reviewed
Feb 3, 2022
go.mod
Outdated
| github.com/prometheus/client_golang v1.11.0 | ||
| github.com/prometheus/client_model v0.2.0 | ||
| github.com/prometheus/common v0.26.0 | ||
| github.com/prometheus/common v0.28.0 | ||
| github.com/pseudomuto/protoc-gen-doc v1.4.1 |
There was a problem hiding this comment.
Did you forget the following?
protoc-gen-doc: v1.4.1 → v1.5.0 (https://github.com/pseudomuto/protoc-gen-doc)
There was a problem hiding this comment.
@cupnes
Sorry, I change the protoc-gen-doc version to v1.5.0.
Signed-off-by: Shinya Hayashi <shinya-hayashi@cybozu.co.jp>
peng225
force-pushed
the
support_kubernetes_v1.23
branch
from
b0eee22
to
cae823f
Compare
llamerada-jp
approved these changes
Feb 4, 2022
cupnes
approved these changes
Feb 4, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #418
EXTERNAL_PROVISIONER_VERSION = 3.0.0 → v3.1.0 (https://github.com/kubernetes-csi/external-provisioner)
EXTERNAL_RESIZER_VERSION = 1.3.0 → v1.4.0 (https://github.com/kubernetes-csi/external-resizer)
NODE_DRIVER_REGISTRAR_VERSION = 2.3.0 → v2.4.0 (https://github.com/kubernetes-csi/node-driver-registrar)
LIVENESSPROBE_VERSION = 2.4.0 → v2.6.0 (https://github.com/kubernetes-csi/livenessprobe)
helm: 3.7.1 → v3.8.0 (https://github.com/helm/helm)
helm-doc: 1.5.0 → v1.7.0 (https://github.com/norwoodj/helm-docs)
protoc: v3.15.0 → v3.19.3 (https://github.com/protocolbuffers/protobuf)
MINIKUBE_VERSION := v1.23.2 → v1.25.1 (https://github.com/kubernetes/minikube)
prometheus/common: v0.26.0 → v0.28.0 (https://github.com/kubernetes/kubernetes/blob/v1.23.3/go.mod#L71-L73)
grpc: v1.42.0 (https://github.com/grpc/grpc)
protobuf: v1.26.0 → v1.27.1 (https://github.com/kubernetes/kubernetes/blob/v1.23.3/go.mod#L102-L103)
YQ: 4.14.1 → 4.18.1 (https://github.com/mikefarah/yq)
golang: 1.16 → v1.17 (https://github.com/golang)
cert-manager: v1.3.1 → v1.7.0 (https://github.com/jetstack/cert-manager)
python: 3.7→3.10 (https://www.python.org/downloads/)
protoc-gen-doc: v1.4.1 → v1.5.0 (https://github.com/pseudomuto/protoc-gen-doc)
spf13/cobra: v1.2.1 → v1.3.0 (https://github.com/spf13/cobra)
spf13/viper v1.8.1 → v1.10.1 (https://github.com/spf13/viper)
protoc-gen-go-grpc: v1.1.0 → v1.2.0 (https://pkg.go.dev/google.golang.org/grpc/cmd/protoc-gen-go-grpc)
klog: v1.0.0 → v2.40.1 (https://github.com/kubernetes/klog)
mount-utils: 0.22.2 → 0.23.3 (https://github.com/kubernetes/mount-utils)
Signed-off-by: Shinya Hayashi shinya-hayashi@cybozu.co.jp