Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use correct downloaded xpi file path #124

Merged
merged 3 commits into from Apr 20, 2020
Merged

fix: use correct downloaded xpi file path #124

merged 3 commits into from Apr 20, 2020

Conversation

iamogbz
Copy link
Contributor

@iamogbz iamogbz commented Apr 19, 2020 •
edited

Description

Fixes #123, uses downloaded xpi path without modifications

Checklist

  • This PR has updated documentation
  • This PR has sufficient testing

DevQA

  • Should be covered by E2Es

Comments

@iamogbz iamogbz requested a review from dbasilio April 19, 2020 20:03
@iamogbz iamogbz marked this pull request as ready for review April 19, 2020 20:03
@iamogbz iamogbz merged commit 1b41d0c into master Apr 20, 2020
@iamogbz iamogbz deleted the fix-123 branch April 20, 2020 05:48
@iamogbz
Copy link
Contributor Author

iamogbz commented Apr 20, 2020

🎉 This PR is included in version 0.2.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbasilio dbasilio Awaiting requested review from dbasilio

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

publishment fails with default parameters due to referring to artifacts/artifacts/XXX.xpi
1 participant
@iamogbz