Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extending opentelementry v3 #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

toneymathews
Copy link
Owner

@toneymathews toneymathews commented Apr 19, 2022

Closes rmosolgo#4001

An attempt at allowing tracing per request as per suggestions in rmosolgo#4001

  • cached_platform_key now accepts the trace phase as a third parameter.
  • OpenTelemetryTracing overrides cached_platform_key to access execution context not available in platform_field_key, platform_authorized_key, platform_resolve_type_key

This PR includes

  • modified copy of the OpenTelemetry implementation to demonstrate how we would make use of PlatformTracing
  • tests to ensure the above works as expected
  • a stub for the OpenTelemetry agent

CI has failed due to rubocop failures in files not associated with this PR.

If this looks good, we are hoping to add this to 1.13.x (< 2) since we haven't yet migrated.

@toneymathews toneymathews force-pushed the extending-opentelementry-v3 branch 3 times, most recently from 923e467 to 4d05c07 Compare May 16, 2022 19:50
@toneymathews toneymathews force-pushed the extending-opentelementry-v3 branch 2 times, most recently from 9feda6a to 036a018 Compare May 25, 2022 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant