Add the wallet_switchEthereumChain method to the eip1193 transport #657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
is this repository maintained any more? seems like there's open PRs from months back... |
tomusdrw
requested changes
Jun 2, 2023
|
|
||
| #[derive(serde::Serialize)] | ||
| #[serde(rename_all = "camelCase")] | ||
| pub struct ChainId { |
There was a problem hiding this comment.
Please move the struct declaration into the function, since I don't think it's required anywhere outside it (or just use json! internally)
Comment on lines
+138
to
+140
| let js_params = JsValue::from_serde(&vec![&ChainId { | ||
| chain_id: chain_id.to_string(), | ||
| }]) |
There was a problem hiding this comment.
might be easier to use json! macro for such a simple parameter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for eip3326, calling
wallet_switchEthereumChain. It will allow a dapp to request a chain switch for a user with a eip1193 transport (such as metamask).There are other methods that go alongside this method, but I'm not sure if this is the canonical way to implement this into
rust-web3, so I only implemented the smallest (simplest) method first.To check the functionality (where 0x01 is the hexadecimal chain id for ethereum):
I'm not sure if the return values are ideomatic to your api either. Any guidance would be helpful as these functions are critical for any user wishing to develop web3 dapps in rust with a eip1193 transport.