Report response parse errors to avoid freezes #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marmistrz
force-pushed
the
ws-parse-errors
branch
from
75fe618
to
a15c237
Compare
marmistrz
force-pushed
the
ws-parse-errors
branch
from
a15c237
to
c6d812d
Compare
tomusdrw
requested changes
Jun 2, 2023
Comment on lines
+269
to
+279
| fn parse_message(data: &[u8]) -> Option<ParsedMessage> { | ||
| if let Ok(notification) = helpers::to_notification_from_slice(data) { | ||
| Some(ParsedMessage::Notification(notification)) | ||
| } else if let Ok(response) = helpers::to_response_from_slice(data) { | ||
| Some(ParsedMessage::Response(response)) | ||
| } else if let Some(id) = helpers::response_id_from_slice(data) { | ||
| Some(ParsedMessage::InvalidResponse(id)) | ||
| } else { | ||
| None | ||
| } | ||
| } |
There was a problem hiding this comment.
I guess it might be better to simply use untagged enum ParsedMessage with default serde deserialize behaviour? Given some tests are written I think it should be simpler to reason about and possibly also faster than manually attempting to parse the response couple of times.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is at least a workaround for the issue reported in #566.
Whether or not we choose to be strict in parsing, we should report the deserialization errors instead of letting the called wait indefinitely.