Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Transaction from account signing public #630

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/api/accounts.rs
Expand Up @@ -36,7 +36,7 @@
}

#[cfg(feature = "signing")]
mod accounts_signing {
pub(crate) mod accounts_signing {
use super::*;
use crate::{
api::Web3,
Expand Down Expand Up @@ -187,15 +187,15 @@
/// A transaction used for RLP encoding, hashing and signing.
#[derive(Debug)]
pub struct Transaction {
pub to: Option<Address>,

Check warning on line 190 in src/api/accounts.rs

View workflow job for this annotation

GitHub Actions / Check, test and build

missing documentation for a struct field

Check warning on line 190 in src/api/accounts.rs

View workflow job for this annotation

GitHub Actions / Check, test and build

missing documentation for a struct field

Check warning on line 190 in src/api/accounts.rs

View workflow job for this annotation

GitHub Actions / Check, test and build

missing documentation for a struct field
pub nonce: U256,

Check warning on line 191 in src/api/accounts.rs

View workflow job for this annotation

GitHub Actions / Check, test and build

missing documentation for a struct field

Check warning on line 191 in src/api/accounts.rs

View workflow job for this annotation

GitHub Actions / Check, test and build

missing documentation for a struct field

Check warning on line 191 in src/api/accounts.rs

View workflow job for this annotation

GitHub Actions / Check, test and build

missing documentation for a struct field
pub gas: U256,

Check warning on line 192 in src/api/accounts.rs

View workflow job for this annotation

GitHub Actions / Check, test and build

missing documentation for a struct field

Check warning on line 192 in src/api/accounts.rs

View workflow job for this annotation

GitHub Actions / Check, test and build

missing documentation for a struct field

Check warning on line 192 in src/api/accounts.rs

View workflow job for this annotation

GitHub Actions / Check, test and build

missing documentation for a struct field
pub gas_price: U256,

Check warning on line 193 in src/api/accounts.rs

View workflow job for this annotation

GitHub Actions / Check, test and build

missing documentation for a struct field

Check warning on line 193 in src/api/accounts.rs

View workflow job for this annotation

GitHub Actions / Check, test and build

missing documentation for a struct field

Check warning on line 193 in src/api/accounts.rs

View workflow job for this annotation

GitHub Actions / Check, test and build

missing documentation for a struct field
pub value: U256,

Check warning on line 194 in src/api/accounts.rs

View workflow job for this annotation

GitHub Actions / Check, test and build

missing documentation for a struct field

Check warning on line 194 in src/api/accounts.rs

View workflow job for this annotation

GitHub Actions / Check, test and build

missing documentation for a struct field

Check warning on line 194 in src/api/accounts.rs

View workflow job for this annotation

GitHub Actions / Check, test and build

missing documentation for a struct field
pub data: Vec<u8>,

Check warning on line 195 in src/api/accounts.rs

View workflow job for this annotation

GitHub Actions / Check, test and build

missing documentation for a struct field

Check warning on line 195 in src/api/accounts.rs

View workflow job for this annotation

GitHub Actions / Check, test and build

missing documentation for a struct field

Check warning on line 195 in src/api/accounts.rs

View workflow job for this annotation

GitHub Actions / Check, test and build

missing documentation for a struct field
pub transaction_type: Option<U64>,

Check warning on line 196 in src/api/accounts.rs

View workflow job for this annotation

GitHub Actions / Check, test and build

missing documentation for a struct field

Check warning on line 196 in src/api/accounts.rs

View workflow job for this annotation

GitHub Actions / Check, test and build

missing documentation for a struct field

Check warning on line 196 in src/api/accounts.rs

View workflow job for this annotation

GitHub Actions / Check, test and build

missing documentation for a struct field
pub access_list: AccessList,

Check warning on line 197 in src/api/accounts.rs

View workflow job for this annotation

GitHub Actions / Check, test and build

missing documentation for a struct field

Check warning on line 197 in src/api/accounts.rs

View workflow job for this annotation

GitHub Actions / Check, test and build

missing documentation for a struct field

Check warning on line 197 in src/api/accounts.rs

View workflow job for this annotation

GitHub Actions / Check, test and build

missing documentation for a struct field
pub max_priority_fee_per_gas: U256,

Check warning on line 198 in src/api/accounts.rs

View workflow job for this annotation

GitHub Actions / Check, test and build

missing documentation for a struct field

Check warning on line 198 in src/api/accounts.rs

View workflow job for this annotation

GitHub Actions / Check, test and build

missing documentation for a struct field

Check warning on line 198 in src/api/accounts.rs

View workflow job for this annotation

GitHub Actions / Check, test and build

missing documentation for a struct field
}

impl Transaction {
Expand Down
3 changes: 3 additions & 0 deletions src/api/mod.rs
Expand Up @@ -28,6 +28,9 @@ pub use self::{
web3::Web3 as Web3Api,
};

#[cfg(feature = "signing")]
pub use self::accounts::accounts_signing::Transaction;

use crate::{
confirm, error,
types::{Bytes, TransactionReceipt, TransactionRequest, U64},
Expand Down