This repository has been archived by the owner on Dec 15, 2023. It is now read-only.
Stat calc #75
Merged
Stat calc #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #75 +/- ##
==========================================
+ Coverage 78.18% 78.46% +0.27%
==========================================
Files 26 27 +1
Lines 1866 1904 +38
Branches 250 255 +5
==========================================
+ Hits 1459 1494 +35
- Misses 364 366 +2
- Partials 43 44 +1
Continue to review full report at Codecov.
|
tomrtk
suggested changes
Jul 7, 2021
|
@MindTooth why did you mark this as a draft? |
Bunch of commits. |
They will all be squashed when merging. |
tomrtk
approved these changes
Jul 7, 2021
JobStats is the pydantic version for model.Job.stats. Also converts labels from `int` to `str` for `JobStat`. A bug surfaced from this where `convert_labels` happens twice. We simply ignore and return if every key is a valid `str` that cannot be cast to an int.
Tests model.Job.stats property, as well as the (de)serialization with pydantic.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JobBare and Job now has a JobStat member with easily reachable statistics for the job.
Closes #54