Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ValueDeserializer creation docs #545

Merged
merged 3 commits into from
Apr 14, 2023
Merged

Update ValueDeserializer creation docs #545

merged 3 commits into from
Apr 14, 2023

Conversation

SomeoneToIgnore
Copy link
Contributor

Closes #544
Make it more clear how to deserialize already parsed toml_edit entities with the new API.

@SomeoneToIgnore SomeoneToIgnore mentioned this pull request Apr 14, 2023
Closed
epage
epage reviewed Apr 14, 2023
View reviewed changes
Copy link
Member

@epage epage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

crates/toml_edit/src/de/value.rs Outdated Show resolved Hide resolved
crates/toml_edit/src/de/value.rs Outdated Show resolved Hide resolved
@SomeoneToIgnore
Copy link
Contributor Author

Thanks, fixed the links and move things up — that naturally required the example adjustments to reflect both cases.
Pushed a commit to address both comments.

@epage
Copy link
Member

epage commented Apr 14, 2023

that naturally required the example adjustments to reflect both cases

Not necessarily.

epage
epage reviewed Apr 14, 2023
View reviewed changes
crates/toml_edit/src/de/value.rs Outdated Show resolved Hide resolved
crates/toml_edit/src/de/value.rs Outdated Show resolved Hide resolved
@SomeoneToIgnore
Copy link
Contributor Author

In that case, let's remove the 2nd example indeed.
The conversion ways are enumerated better now, that's already good.

@epage epage merged commit bd4bde0 into toml-rs:main Apr 14, 2023
7 checks passed
@epage
Copy link
Member

epage commented Apr 14, 2023

Thanks for doing this!

@SomeoneToIgnore SomeoneToIgnore deleted the more-valuedeserializer-creation-docs branch April 15, 2023 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epage epage epage left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide an easy way to deserialize the toml_edit::Item
2 participants
@SomeoneToIgnore @epage