Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test against ember-data ^3.8.0 #208

Merged
merged 8 commits into from Apr 11, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 4 additions & 2 deletions .travis.yml
Expand Up @@ -5,7 +5,9 @@ node_js:
- "10"

before_install:
- if [[ `npm -v` != 3* ]]; then npm i -g npm@3; fi
- npm config set spin false

# TODO: remove when we stop testing against node 6
- if [[ `npm -v` < 6* ]]; then npm i -g npm@6; fi

- npm install -g bower
- bower --version
4 changes: 1 addition & 3 deletions appveyor.yml
@@ -1,6 +1,5 @@
environment:
matrix:
- nodejs_version: "4"
- nodejs_version: "6"
- nodejs_version: "8"
- nodejs_version: "10"
Expand All @@ -12,8 +11,7 @@ init:
# Install scripts. (runs after repo cloning)
install:
- ps: Install-Product node $env:nodejs_version
- npm i -g npm@^3
- npm config set spin false
- npm i -g npm@^6
- npm install -g bower
- npm install

Expand Down
2 changes: 1 addition & 1 deletion lib/utilities/pristine.js
Expand Up @@ -95,7 +95,7 @@ function installPristineApp(appName, options) {
hasBowerComponents,
skipNpm,
emberVersion: options.emberVersion || 'canary',
emberDataVersion: options.emberDataVersion || 'emberjs/data#master'
emberDataVersion: options.emberDataVersion || '~3.8.0'
};

promise = promise
Expand Down
2 changes: 1 addition & 1 deletion package.json
Expand Up @@ -34,7 +34,7 @@
"devDependencies": {
"chai": "^4.0.2",
"cross-env": "^5.0.0",
"ember-cli": "~2.17.1",
"ember-cli": "~3.8.0",
"ember-cli-fastboot": "^1.0.0",
"eslint-config-sane": "^0.6.0",
"eslint-plugin-prefer-let": "^1.0.1",
Expand Down