add test case for HTTPFetchClient

tokuhirom · Feb 28, 2024 · c074990 · c074990
1 parent b713ea5
commit c074990
Show file tree

Hide file tree

Showing 13 changed files with 297 additions and 25 deletions.
diff --git a/generator/src/main/resources/line-bot-sdk-nodejs-generator/api-single.pebble b/generator/src/main/resources/line-bot-sdk-nodejs-generator/api-single.pebble
@@ -44,10 +44,10 @@ export class {{operations.classname}} {
         });
     }
 
-    private parseHTTPResponse(response: Response) {
+    private async parseHTTPResponse(response: Response) {
         const { LINE_REQUEST_ID_HTTP_HEADER_NAME } = Types;
         let resBody: Record<string, any> = {
-            ...response.json(),
+            ...await response.json(),
         };
         if (response.headers.get(LINE_REQUEST_ID_HTTP_HEADER_NAME)) {
             resBody[LINE_REQUEST_ID_HTTP_HEADER_NAME] =

diff --git a/lib/channel-access-token/api/channelAccessTokenClient.ts b/lib/channel-access-token/api/channelAccessTokenClient.ts
@@ -47,10 +47,10 @@ export class ChannelAccessTokenClient {
     });
   }
 
-  private parseHTTPResponse(response: Response) {
+  private async parseHTTPResponse(response: Response) {
     const { LINE_REQUEST_ID_HTTP_HEADER_NAME } = Types;
     let resBody: Record<string, any> = {
-      ...response.json(),
+      ...(await response.json()),
     };
     if (response.headers.get(LINE_REQUEST_ID_HTTP_HEADER_NAME)) {
       resBody[LINE_REQUEST_ID_HTTP_HEADER_NAME] = response.headers.get(

diff --git a/lib/http-fetch.ts b/lib/http-fetch.ts
@@ -10,13 +10,13 @@ export interface FetchRequestConfig {
 interface httpFetchClientConfig {
   baseURL: string;
   defaultHeaders: Record<string, string>;
-  responseParser: <T>(res: Response) => T;
+  responseParser: <T>(res: Response) => Promise<T>;
 }
 
 export default class HTTPFetchClient {
   private readonly baseURL: string;
   private readonly defaultHeaders: Record<string, string>;
-  private readonly responseParser: <T>(res: Response) => T;
+  private readonly responseParser: <T>(res: Response) => Promise<T>;
 
   constructor(config: httpFetchClientConfig) {
     this.baseURL = config.baseURL;
@@ -136,7 +136,6 @@ export default class HTTPFetchClient {
     this.checkResponseStatus(response);
     return response.json();
   }
-
   public async postBinaryContent<T>(url: string, body: Blob): Promise<T> {
     const response = await fetch(this.baseURL + url, {
       method: "POST",

diff --git a/lib/insight/api/insightClient.ts b/lib/insight/api/insightClient.ts
@@ -49,10 +49,10 @@ export class InsightClient {
     });
   }
 
-  private parseHTTPResponse(response: Response) {
+  private async parseHTTPResponse(response: Response) {
     const { LINE_REQUEST_ID_HTTP_HEADER_NAME } = Types;
     let resBody: Record<string, any> = {
-      ...response.json(),
+      ...(await response.json()),
     };
     if (response.headers.get(LINE_REQUEST_ID_HTTP_HEADER_NAME)) {
       resBody[LINE_REQUEST_ID_HTTP_HEADER_NAME] = response.headers.get(

diff --git a/lib/liff/api/liffClient.ts b/lib/liff/api/liffClient.ts
@@ -48,10 +48,10 @@ export class LiffClient {
     });
   }
 
-  private parseHTTPResponse(response: Response) {
+  private async parseHTTPResponse(response: Response) {
     const { LINE_REQUEST_ID_HTTP_HEADER_NAME } = Types;
     let resBody: Record<string, any> = {
-      ...response.json(),
+      ...(await response.json()),
     };
     if (response.headers.get(LINE_REQUEST_ID_HTTP_HEADER_NAME)) {
       resBody[LINE_REQUEST_ID_HTTP_HEADER_NAME] = response.headers.get(

diff --git a/lib/manage-audience/api/manageAudienceBlobClient.ts b/lib/manage-audience/api/manageAudienceBlobClient.ts
@@ -45,10 +45,10 @@ export class ManageAudienceBlobClient {
     });
   }
 
-  private parseHTTPResponse(response: Response) {
+  private async parseHTTPResponse(response: Response) {
     const { LINE_REQUEST_ID_HTTP_HEADER_NAME } = Types;
     let resBody: Record<string, any> = {
-      ...response.json(),
+      ...(await response.json()),
     };
     if (response.headers.get(LINE_REQUEST_ID_HTTP_HEADER_NAME)) {
       resBody[LINE_REQUEST_ID_HTTP_HEADER_NAME] = response.headers.get(

diff --git a/lib/manage-audience/api/manageAudienceClient.ts b/lib/manage-audience/api/manageAudienceClient.ts
@@ -59,10 +59,10 @@ export class ManageAudienceClient {
     });
   }
 
-  private parseHTTPResponse(response: Response) {
+  private async parseHTTPResponse(response: Response) {
     const { LINE_REQUEST_ID_HTTP_HEADER_NAME } = Types;
     let resBody: Record<string, any> = {
-      ...response.json(),
+      ...(await response.json()),
     };
     if (response.headers.get(LINE_REQUEST_ID_HTTP_HEADER_NAME)) {
       resBody[LINE_REQUEST_ID_HTTP_HEADER_NAME] = response.headers.get(

diff --git a/lib/messaging-api/api/messagingApiBlobClient.ts b/lib/messaging-api/api/messagingApiBlobClient.ts
@@ -45,10 +45,10 @@ export class MessagingApiBlobClient {
     });
   }
 
-  private parseHTTPResponse(response: Response) {
+  private async parseHTTPResponse(response: Response) {
     const { LINE_REQUEST_ID_HTTP_HEADER_NAME } = Types;
     let resBody: Record<string, any> = {
-      ...response.json(),
+      ...(await response.json()),
     };
     if (response.headers.get(LINE_REQUEST_ID_HTTP_HEADER_NAME)) {
       resBody[LINE_REQUEST_ID_HTTP_HEADER_NAME] = response.headers.get(

diff --git a/lib/messaging-api/api/messagingApiClient.ts b/lib/messaging-api/api/messagingApiClient.ts
@@ -88,10 +88,10 @@ export class MessagingApiClient {
     });
   }
 
-  private parseHTTPResponse(response: Response) {
+  private async parseHTTPResponse(response: Response) {
     const { LINE_REQUEST_ID_HTTP_HEADER_NAME } = Types;
     let resBody: Record<string, any> = {
-      ...response.json(),
+      ...(await response.json()),
     };
     if (response.headers.get(LINE_REQUEST_ID_HTTP_HEADER_NAME)) {
       resBody[LINE_REQUEST_ID_HTTP_HEADER_NAME] = response.headers.get(

diff --git a/lib/module-attach/api/lineModuleAttachClient.ts b/lib/module-attach/api/lineModuleAttachClient.ts
@@ -45,10 +45,10 @@ export class LineModuleAttachClient {
     });
   }
 
-  private parseHTTPResponse(response: Response) {
+  private async parseHTTPResponse(response: Response) {
     const { LINE_REQUEST_ID_HTTP_HEADER_NAME } = Types;
     let resBody: Record<string, any> = {
-      ...response.json(),
+      ...(await response.json()),
     };
     if (response.headers.get(LINE_REQUEST_ID_HTTP_HEADER_NAME)) {
       resBody[LINE_REQUEST_ID_HTTP_HEADER_NAME] = response.headers.get(

diff --git a/lib/module/api/lineModuleClient.ts b/lib/module/api/lineModuleClient.ts
@@ -47,10 +47,10 @@ export class LineModuleClient {
     });
   }
 
-  private parseHTTPResponse(response: Response) {
+  private async parseHTTPResponse(response: Response) {
     const { LINE_REQUEST_ID_HTTP_HEADER_NAME } = Types;
     let resBody: Record<string, any> = {
-      ...response.json(),
+      ...(await response.json()),
     };
     if (response.headers.get(LINE_REQUEST_ID_HTTP_HEADER_NAME)) {
       resBody[LINE_REQUEST_ID_HTTP_HEADER_NAME] = response.headers.get(

diff --git a/lib/shop/api/shopClient.ts b/lib/shop/api/shopClient.ts
@@ -45,10 +45,10 @@ export class ShopClient {
     });
   }
 
-  private parseHTTPResponse(response: Response) {
+  private async parseHTTPResponse(response: Response) {
     const { LINE_REQUEST_ID_HTTP_HEADER_NAME } = Types;
     let resBody: Record<string, any> = {
-      ...response.json(),
+      ...(await response.json()),
     };
     if (response.headers.get(LINE_REQUEST_ID_HTTP_HEADER_NAME)) {
       resBody[LINE_REQUEST_ID_HTTP_HEADER_NAME] = response.headers.get(