serde: record errors as a struct with fields for sources #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR changes `valuable-serde`'s recording of `dyn Error` values to record the error as a `serde` struct with `message` and `source` fields. This way, we can serialize errors with source chains more nicely. When the backtrace support for `std::error::Error` is stable, we could also record backtraces as a field. We could even consider adding a build script to detect the nightly compiler and conditionally enable a `cfg` for backtrace support, but that seems better left to a follow-up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #89
This PR changes
valuable-serde's recording ofdyn Errorvalues torecord the error as a
serdestruct withmessageandsourcefields.This way, we can serialize errors with source chains more nicely.
When the backtrace support for
std::error::Erroris stable, we couldalso record backtraces as a field. We could even consider adding a build
script to detect the nightly compiler and conditionally enable a
cfgfor backtrace support, but that seems better left to a follow-up.