chore: fix clippy lints #2961
Merged
chore: fix clippy lints #2961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mladedav
requested review from
a team,
hawkw,
carllerche and
davidbarsky
as code owners
hawkw
approved these changes
May 3, 2024
| @@ -541,10 +541,6 @@ mod tests { | |||
| Collect, | |||
| }; | |||
|
|
|||
| #[derive(Debug)] | |||
| struct DoesNothing; | |||
| impl<C: Collect> Subscribe<C> for DoesNothing {} | |||
There was a problem hiding this comment.
I can't recall what this code was intended to test...I wonder if it was testing that a trivial Subscribe impl compiles? But because we have other implementations in the test suite, I think deleting it is fine.
| @@ -33,7 +33,7 @@ default-features = false | |||
| features = ["fmt", "std"] | |||
|
|
|||
| [dev-dependencies] | |||
| criterion = { version = "0.3.6", default_features = false } | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
New lints were added to 1.78 which breaks CI.
Solution
New lints are fixed. I also fixed lints present in the beta channel for 1.79.