Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ensure the None-layer doesn't override the max-level erroneously #2321
ensure the None-layer doesn't override the max-level erroneously #2321
Changes from 5 commits
51afb35
aed92ac
309879c
56749e3
8c90a4f
70e6ce8
3b9a32e
582f3e9
abd1030
c692670
870ba11
64774e5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i notice all these tests order the layers so that we have another layer, and then a
None
. we should probably also have tests that the same cases work when theNone
layer is on the inside (e.g.,Registry
,None
,BasicLayer
instead ofRegistry
,BasicLayer
,None
)?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added tests for this in abd1030 and it turns out we weren't handling that case nicely, so i fixed it in 870ba11. i'm not super happy with the code, but it does at least do the right thing now...