Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set minimal version of syn #1960

Merged
merged 2 commits into from Feb 28, 2022
Merged

Set minimal version of syn #1960

merged 2 commits into from Feb 28, 2022

Conversation

udoprog
Copy link
Contributor

@udoprog udoprog commented Feb 26, 2022

This sets the minimal version of syn to 1.0.43 - the actual minimal version that is required to build tracing-attributes.

See this build failure in Tokio: https://github.com/tokio-rs/tokio/runs/5344598894?check_suite_focus=true

CC: tokio-rs/tokio#4513

@udoprog udoprog requested review from hawkw, davidbarsky and a team as code owners February 26, 2022 13:44
Copy link
Member

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, good catch!

the clippy failure on this PR is unrelated; it's probably a new lint that landed in Rust 1.59. I'll fix that separately.

@hawkw hawkw enabled auto-merge (squash) February 28, 2022 20:52
@hawkw hawkw merged commit 5f80628 into tokio-rs:master Feb 28, 2022
@udoprog udoprog deleted the minimal-versions branch March 1, 2022 02:23
hawkw pushed a commit that referenced this pull request Mar 8, 2022
This sets the minimal version of `syn` to `1.0.43` - the actual minimal
version that is required to build `tracing-attributes`.

See this build failure in Tokio:
https://github.com/tokio-rs/tokio/runs/5344598894?check_suite_focus=true

CC: tokio-rs/tokio#4513
hawkw pushed a commit that referenced this pull request Mar 8, 2022
This sets the minimal version of `syn` to `1.0.43` - the actual minimal
version that is required to build `tracing-attributes`.

See this build failure in Tokio:
https://github.com/tokio-rs/tokio/runs/5344598894?check_suite_focus=true

CC: tokio-rs/tokio#4513
hawkw added a commit that referenced this pull request Mar 8, 2022
# 0.1.20 (March 8, 2022)

### Fixed

- Compilation failure with `--minimal-versions` due to a too-permissive
  `syn` dependency ([#1960])

### Changed

- Bumped minimum supported Rust version (MSRV) to 1.49.0 ([#1913])

Thanks to new contributor @udoprog for contributing to this release!

[#1960]: #1960
[#1913]: #1913
hawkw added a commit that referenced this pull request Mar 8, 2022
# 0.1.20 (March 8, 2022)

### Fixed

- Compilation failure with `--minimal-versions` due to a too-permissive
  `syn` dependency ([#1960])

### Changed

- Bumped minimum supported Rust version (MSRV) to 1.49.0 ([#1913])

Thanks to new contributor @udoprog for contributing to this release!

[#1960]: #1960
[#1913]: #1913
hawkw added a commit that referenced this pull request Mar 9, 2022
# 0.1.32 (March 8th, 2022)

This release reduces the overhead of creating and dropping disabled
spans significantly, which should improve performance when no `tracing`
subscriber is in use or when spans are disabled by a filter.

### Fixed

- **attributes**: Compilation failure with `--minimal-versions` due to a
  too-permissive `syn` dependency ([#1960])

### Changed

- Reduced `Drop` overhead for disabled spans ([#1974])
- `tracing-attributes`: updated to [0.1.20][attributes-0.1.20]

[#1974]: #1974
[#1960]: #1960
[attributes-0.1.20]: https://github.com/tokio-rs/tracing/releases/tag/tracing-attributes-0.1.20
hawkw added a commit that referenced this pull request Mar 9, 2022
# 0.1.32 (March 8th, 2022)

This release reduces the overhead of creating and dropping disabled
spans significantly, which should improve performance when no `tracing`
subscriber is in use or when spans are disabled by a filter.

### Fixed

- **attributes**: Compilation failure with `--minimal-versions` due to a
  too-permissive `syn` dependency ([#1960])

### Changed

- Reduced `Drop` overhead for disabled spans ([#1974])
- `tracing-attributes`: updated to [0.1.20][attributes-0.1.20]

[#1974]: #1974
[#1960]: #1960
[attributes-0.1.20]: https://github.com/tokio-rs/tracing/releases/tag/tracing-attributes-0.1.20
hawkw added a commit that referenced this pull request Mar 9, 2022
# 0.1.32 (March 8th, 2022)

This release reduces the overhead of creating and dropping disabled
spans significantly, which should improve performance when no `tracing`
subscriber is in use or when spans are disabled by a filter.

### Fixed

- **attributes**: Compilation failure with `--minimal-versions` due to a
  too-permissive `syn` dependency ([#1960])

### Changed

- Reduced `Drop` overhead for disabled spans ([#1974])
- `tracing-attributes`: updated to [0.1.20][attributes-0.1.20]

[#1974]: #1974
[#1960]: #1960
[attributes-0.1.20]: https://github.com/tokio-rs/tracing/releases/tag/tracing-attributes-0.1.20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants