-
Notifications
You must be signed in to change notification settings - Fork 664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tracing: fix macros "use of moved value" with log #1823
Merged
Merged
Commits on Jan 9, 2022
-
tracing: fix macros "use of moved value" with log
This changes the event macro (and all the upstream macros like info!), so that it only uses each field once when the log feature is enabled. Previously, the `field` token trees would be substituted into the log macro invocation and the `ValueSet`, potentially meaning they are executed more than once. This change generates the log using the `ValueSet` meaning the token trees are only substituted once. Fixes: tokio-rs#196, tokio-rs#1739
Configuration menu - View commit details
-
Copy full SHA for 874a462 - Browse repository at this point
Copy the full SHA 874a462View commit details -
tracing: fix span macros with log feature
Fixes the span macro to only substitute the field expressions once when the log feature is enabled. This stops enabling the log feature causing "use of moved value" errors and other odd behaviour. # Please enter the commit message for your changes. Lines starting # with '#' will be ignored, and an empty message aborts the commit. # # On branch macros-with-log # Your branch is up to date with 'origin/macros-with-log'. # # Changes to be committed: # modified: ../tracing/src/macros.rs # # Changes not staged for commit: # modified: Cargo.toml # # Untracked files: # examples/log-move.rs #
Configuration menu - View commit details
-
Copy full SHA for bc81ef5 - Browse repository at this point
Copy the full SHA bc81ef5View commit details
Commits on Jan 11, 2022
-
tracing: revert fix span macros with log feature
This reverts commit bc81ef5. The issue with the event macro does not apply to the span macro.
Configuration menu - View commit details
-
Copy full SHA for 0ad95a9 - Browse repository at this point
Copy the full SHA 0ad95a9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 68b56d0 - Browse repository at this point
Copy the full SHA 68b56d0View commit details -
Configuration menu - View commit details
-
Copy full SHA for c20567a - Browse repository at this point
Copy the full SHA c20567aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 50fd7f2 - Browse repository at this point
Copy the full SHA 50fd7f2View commit details
Commits on Jan 17, 2022
-
Configuration menu - View commit details
-
Copy full SHA for b4c6208 - Browse repository at this point
Copy the full SHA b4c6208View commit details
Commits on Jan 18, 2022
-
Configuration menu - View commit details
-
Copy full SHA for ce02eda - Browse repository at this point
Copy the full SHA ce02edaView commit details
Commits on Jan 19, 2022
-
Configuration menu - View commit details
-
Copy full SHA for a691c5b - Browse repository at this point
Copy the full SHA a691c5bView commit details
Commits on Jan 23, 2022
-
Configuration menu - View commit details
-
Copy full SHA for a4e8d26 - Browse repository at this point
Copy the full SHA a4e8d26View commit details
Commits on Jan 28, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 0c1ab2b - Browse repository at this point
Copy the full SHA 0c1ab2bView commit details
Commits on Jan 29, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 794040e - Browse repository at this point
Copy the full SHA 794040eView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.