attributes: fix #[instrument] skipping code when returning pinned futures
#1297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As @hawkw pointed out in #1296 (comment), it might be interesting to add tests to prevent such breakage in the future. |
hawkw
changed the title
#[instrument] deleting code when returning pinned futures
hawkw
changed the title
#[instrument] deleting code when returning pinned futures#[instrument] skipping code when returning pinned futures
|
Last CI failure was due to flaky tests, restarted it. |
hawkw
pushed a commit
that referenced
this pull request
Mar 12, 2021
hawkw
pushed a commit
that referenced
this pull request
Mar 12, 2021
hawkw
added a commit
that referenced
this pull request
Mar 12, 2021
# 0.1.15 (March 12, 2021) ### Fixed - `#[instrument]` on functions returning `Box::pin`ned futures incorrectly skipping function bodies prior to returning a future ([#1297]) Thanks to @nightmared for contributing to this release! [#1297]: #1297
hawkw
added a commit
that referenced
this pull request
Mar 12, 2021
# 0.1.15 (March 12, 2021) ### Fixed - `#[instrument]` on functions returning `Box::pin`ned futures incorrectly skipping function bodies prior to returning a future ([#1297]) Thanks to @nightmared for contributing to this release! [#1297]: #1297
kaffarell
pushed a commit
to kaffarell/tracing
that referenced
this pull request
May 22, 2024
# 0.1.15 (March 12, 2021) ### Fixed - `#[instrument]` on functions returning `Box::pin`ned futures incorrectly skipping function bodies prior to returning a future ([tokio-rs#1297]) Thanks to @nightmared for contributing to this release! [tokio-rs#1297]: tokio-rs#1297
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1296.
I had forgotten to use all the input statements in #1228, so we would delete nearly all the statement of sync functions that return a boxed future :/