runtime: fix double-increment of num_idle_threads when shutdown #6440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liuq19
force-pushed
the
fix/blockingpool
branch
from
1867598
to
44d11ff
Compare
mox692
added
M-runtime
Darksonn
reviewed
Mar 30, 2024
Comment on lines
+530
to
+533
| // Work was produced, and we "took" it (by decrementing num_notify). | ||
| // This means that num_idle was decremented once for our wakeup. | ||
| // But, since we are exiting, we need to "undo" that, as we'll stay idle. | ||
| self.metrics.inc_num_idle_threads(); |
There was a problem hiding this comment.
This comment is confusing to me. Where did we decrement num_notify?
I guess what's happening here is that when waking is up, the counter is decremented, so this increment is there to counteract that.
But that's not what the comment says. Also, what if wait_timeout returned due to the timeout triggering, rather than due to us being woken by another thread?
|
Any update on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix #6439
Solution
Adjust the order of code and make the count of
num_idle_threadscorrect