Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tokio: fix remaining issues about atomic_u64_static_once_cell.rs #5374

Merged
merged 5 commits into from Jan 14, 2023
Merged

tokio: fix remaining issues about atomic_u64_static_once_cell.rs #5374

merged 5 commits into from Jan 14, 2023

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented Jan 13, 2023

Motivation

Fixes #5373
Closes #5358

Solution

  • Add check for no_atomic_u64 & no_const_mutex_new (condition to atomic_u64_static_once_cell.rs is compiled)
  • Allow unused_imports in TARGET_ATOMIC_U64_PROBE. I also tested other *_PROBE and found no other errors triggered by -D warning.
  • Fix cfg of util::once_cell module

@taiki-e taiki-e added the A-tokio Area: The main tokio crate label Jan 13, 2023
@carllerche
Copy link
Member

Awesome, thanks.

@carllerche carllerche merged commit 40782ef into master Jan 14, 2023
@carllerche carllerche deleted the taiki-e/atomic64 branch January 14, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carllerche carllerche carllerche approved these changes

Assignees
No one assigned
Labels
A-tokio Area: The main tokio crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setting -Dwarnings breaks feature detection in build.rs Ensure that the atomic u64 mock is properly tested
2 participants
@taiki-e @carllerche