Add broadcast::Sender::len #5343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The binary search can race with updates to |
sfackler
commented
Jan 4, 2023
| while low < high { | ||
| let mid = low + (high - low) / 2; | ||
| let idx = base_idx.wrapping_add(mid) & self.shared.mask; | ||
| if self.shared.buffer[idx].read().unwrap().rem.load(SeqCst) == 0 { |
There was a problem hiding this comment.
I think this can probably be a relaxed load rather than sequentially consistent, but haven't thought too carefully about it.
|
Ping! |
Darksonn
reviewed
Jan 11, 2023
There was a problem hiding this comment.
Sorry about the delay. It looks correct, but its rather complicated, so I would like to see a more comprehensive test. Perhaps something that randomly chooses between "recv on chan 1, recv on chan 2, send a message" and checks that the length is correct between each iteration, for 1000 iterations?
|
Will do! |
|
Updated with a test that performs random operations and compares Sender::len against Receiver::len. |
Darksonn
reviewed
Jan 11, 2023
|
Updated! |
crapStone
pushed a commit
to Calciumdibromid/CaBr2
that referenced
this pull request
Feb 2, 2023
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [tokio](https://tokio.rs) ([source](https://github.com/tokio-rs/tokio)) | dependencies | minor | `1.24.2` -> `1.25.0` | | [tokio](https://tokio.rs) ([source](https://github.com/tokio-rs/tokio)) | dev-dependencies | minor | `1.24.2` -> `1.25.0` | --- ### Release Notes <details> <summary>tokio-rs/tokio</summary> ### [`v1.25.0`](https://github.com/tokio-rs/tokio/releases/tag/tokio-1.25.0): Tokio v1.25.0 ##### 1.25.0 (January 28, 2023) ##### Fixed - rt: fix runtime metrics reporting ([#​5330]) ##### Added - sync: add `broadcast::Sender::len` ([#​5343]) ##### Changed - fs: increase maximum read buffer size to 2MiB ([#​5397]) [#​5330]: tokio-rs/tokio#5330 [#​5343]: tokio-rs/tokio#5343 [#​5397]: tokio-rs/tokio#5397 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMTYuMSIsInVwZGF0ZWRJblZlciI6IjM0LjExOS4yIn0=--> Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1761 Reviewed-by: crapStone <crapstone@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the head index for each receiver isn't stored in a location accessible from the sender, we need to instead binary search for the last value with remaining readers.
Closes #5334